Antoine du Hamel
Antoine du Hamel
It expects `ncu-config get branch` to return `main`, could it be that it is set to `v22.x-staging` on your local machine?
Oh! My bad, I didn't test that case, tbh I thought `main` would be the default already.
So I tried reproducing by removing the setting for the branch name, and I immediately got an error: ```console $ git node release -S --promote https://github.com/nodejs/node/pull/54966 ⚠ You have not...
FWIW you can delete the local tag as long as you haven't pushed it. > ? Cherry-pick release commit to the default branch? Yes > Switched to branch 'v20.x-staging' It...
> It is v20.x-staging, which is normal from my pov Does it need to be `v20.x-staging` for something else? Landing backport PR maybe? Asking because I'm wondering if we should...
I've confirmed that to land a (backport or not) PR to a staging branch, NCU request you to set a different branch in your config. I've updated the promotion script...
I've tried it with the v18.20.5 release, and did not get any blocker. I'm tempted to land it, we might still want to iterate on it but I think it's...
FYI this was already suggested (and rejected) in #57215.
> I also don't understand why Node.js insists on this limitation. You say that when you just gave an example of why we cannot assume we'd be able to transpile...
> Seems obvious that we should be able to configure this as we want, no? You could use a loader (module hooks), that way you could force Node.js to transpile...