Antoine du Hamel
Antoine du Hamel
Do we create releases with GHA? Not on this repo I don’t think
Ah you meant opening the release proposal PR, not creating the GH release
> [#58226](https://github.com/nodejs/node/pull/58226) was opened by the workflow and triggered the workflows. To be more precise, opening it did not trigger the workflows, marking it as Ready for reviews did.
Can we backport this to LTS? Should we add the lts-watch labels?
> Should I also squash the PR or leave the rest as is? As you prefer, in any case it will get squashed upon merging.
FWIW, it's already possible to detach worker's standard IO: ```console $ node -e "new (require('worker_threads').Worker)('console.error(4)', {eval:true})" 4 $ node -e "new (require('worker_threads').Worker)('console.error(4)', {eval:true, stderr:true})" $ ```
The remaining commits are causing CI failures on v22.x-staging
@joyeecheung I meant 3ac8c686a3d5ce7c03592ada8e5c1f90b2aaf985...0d3c6bb09b5c71fa12f9787812300a469589e94d – https://github.com/nodejs/node/commit/eef37d00cb and https://github.com/nodejs/node/commit/df2a36bfcc already found their way into 22.16.0
> Can someone start a CITGM if they thinks it's necessary. IMO we can use the most recent main branch CITGM for comparison I doubt we have any package on...
> In short: everything was working fine How is it working fine if it reports `REPLACEME` as an invalid version?