Ping Xie

Results 174 comments of Ping Xie

Windows doesn't support fork() natively. The child process doesn't inherit the parent process's address space. Some emulation was done in WSL V1 but I don't think the performance is good...

@QuChen88 I read three questions/callouts in your comment. 1. **What** performance metrics to collect on the client side? 2. **Where** to store the client performance profile? 3. **How** to collect...

I don't think we should set a limit on the number of clients per language. The client ecosystem is big and different clients can focus on different areas. For instance,...

On the flip side though, I can also see the (valid) argument that "why don't we consolidate the efforts into one official client and make it the best all around?"...

I have not taken a closer look at the PR but at the minimum I think we need a config to opt in io_uring. I am also suspecting that the...

>The core numbers will not affect the perf gain, you can refer the server config I post in top comment, io-threads is disabled, the maximum CPU utilized is 1, the...

Yeah this kind of changes requires the reviewers to block off some decent amount of time and to really think through it holistically. This week is really busy for the...

Thanks @lipzhu! I am generally aligned with the high level idea (and good to know that you don't use polling). I do have some high level feedback around the code...

@lipzhu, looking at your results above, the amount of the read calls jumps out too. It will be great if you could apply io-uring to the query path as well....

Does option 1 require a change to the module build process? We currently build each module into its own .so file. Does option 2 affect the distribution only? or it...