Ping Xie

Results 271 comments of Ping Xie
trafficstars

>I'd very much like to hear other peoples thoughts about what "move it into a module" means. I think we are a bit off topic since the proposal here is...

I assume the proposed version scheme is meant to track the compatibility of the wire protocol (in terms of new commands/flags/etc)? I am generally aligned with the version scheme. We...

>This behaviour makes sending to both channels a little more complicated. Can you elaborate a bit about the problem of double publishing in this case? I would assume the client...

>@PingXie how do you know all clients would do that? I don't know. I was just comparing the non-redirection case (where the client is getting unsolicited messages) vs the normal...

> (If I'm not mistaken) Non-redirection works for RESP3 only and the client gets push messages. They're not unsolicited. Why would they be? I think [this](https://github.com/valkey-io/valkey/blob/unstable/src/tracking.c#L307) code pointer is what...

> We do have some special code to allow for active defragmentation of Jemalloc arenas, so we might also want to figure out how to implement that in mimalloc. defrag...

+1 on all, @mattsta! These are all great points and suggestions! These changes would have little impact on the existing users but would go a long way to support future...

> > REDISMODULE will be changed as well? such as XXXMODULE? ^_^ > > We break existing modules if we do that, right? We can provide a compatibility layer of...

> There are lots of questions here. I think we need to ask some law folks or check the source code of other forks, how much they changed. Agreed and...

> So, registering on the server side for `RedisModule_` wouldn't be a trademark violation? This goes back to @zuiderkwast's earlier comment (https://github.com/placeholderkv/placeholderkv/issues/25#issuecomment-2018976668). I guess one option could be to make...