Ping Xie
Ping Xie
> I like the idea of tracking lua errors in a separate RAX, however it can't just be based off of `scriptIsRunning`, since the script could generate normal error messages....
> It also makes this definitely a break changing for users that are using this feature, as opposed to just a breaking change for users that are misusing the feature....
> > We could pass a flag to it to differentiate custom lua errors? > > Yes. They could be emulating a normal error though. I wouldn't consider these "emulated"...
> Can we just add multi-`PUBLISH channel message [ message ... ]` now, together with #557, and get it over with? We haven't needed any flags or other args ti...
No I am not advocating scope creep here. I was commenting on the issue itself without a timeline attached. Speaking of #557, I actually would like us to think weigh...
> We can use this action to avoid implementing this: https://github.com/jidicula/clang-format-action > > Then the job becomes > > ``` > runs-on: ubuntu-latest > steps: > - uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 #...
@bjosv can you please take a look at this PR when you get a chance? I suspect that `jidicula/clang-format-action` is not picking up the .clang-format config file. However, I noticed...
Thanks @bjosv! The below change looks weird to me. I haven't figured a way to tell clang-format to remove the spaces aroud "&". All the styles I've tried left spaces...
> > I haven't figured a way to tell clang-format to remove the spaces aroud "&" > > This seems fixed in clang-format-17, but I couldn't find anything in release...
So I ended up using a custom action. 1. jidicula/clang-format-action uses clang-format 18.1.6 but I only managed to install 18.1.3 on my box. These two however don't agree with each...