Ping Xie

Results 271 comments of Ping Xie
trafficstars

I think the primary constraint here is application compatibility. We would like to make sure the very first release is as compatible as possible with 7.2.4 so that existing users...

> @zuiderkwast @PingXie Thanks for the review. Could you PTAL once again? > Thanks for reducing the scope of this pr. I think we still need a uber decision/guidance on...

> > > @zuiderkwast @PingXie Thanks for the review. Could you PTAL once again? > > > > > > > > > > > > > Thanks for reducing...

> @placeholderkv/core-team Shall we maintain an issue with list of new changes or should we just attach a label `breaking-changes` to the PR(s), which will be reviewed by the release...

> @PingXie @zuiderkwast > > * Sticking to `valkey.conf` to avoid any ambiguity (getting rid of generic `configuration file` comments). > * Moving the SERVER_DEF_NAME out of this PR and...

Try this https://stackoverflow.com/questions/5189560/how-do-i-squash-my-last-n-commits-together

> @guillemj Regarding jemalloc, I believe we need to upstream this commit by Oran Agra: [29d7f97](https://github.com/valkey-io/valkey/commit/29d7f97c96dd19db7200cf49595478be2e72be7f) > > It's been discussed here [jemalloc/jemalloc#566](https://github.com/jemalloc/jemalloc/issues/566). @zuiderkwast, I took a quick look at...

btw, we should probably track the de-vendoring of different dependents in their own issues. The reasons for vendoring and the solutions will likely be different.

"KV" is likely selling this project short IMO. I also feel that we should move on from "*dis". What happened has happened. Let's move on and build something amazing with...

@valkey-io/contributors @mattsta