valkey icon indicating copy to clipboard operation
valkey copied to clipboard

[NEW] Native windows support

Open kzhsw opened this issue 1 year ago • 7 comments

The problem/use-case that the feature addresses

Make it run natively, without cygwin or wsl, on microsoft windows system.

Description of the feature

Currently it does not build or run on windows, make windows users harder to development and test their program using redis protocol. With native windows support, users can setup development environment more easily. There are some existing work on this, but not actively mantained now.

Alternatives you've considered

Additional information

Any additional information that is relevant to the feature request.

kzhsw avatar Mar 30 '24 00:03 kzhsw

The code is written for Posix systems. Native Windows support would require a huge effort since many concepts are very different in that OS.

zuiderkwast avatar Mar 30 '24 17:03 zuiderkwast

I was the original poster (OP) for this issue https://github.com/redis/redis/issues/9728

If there is interest let me / my ppl know

SamuelMarks avatar Mar 30 '24 19:03 SamuelMarks

Yeah, let's leave this and see there is strong interest in support for windows. I think the need has dropped significantly because of WSL from when the issue was already opened.

madolson avatar Mar 31 '24 04:03 madolson

Windows doesn't support fork() natively. The child process doesn't inherit the parent process's address space. Some emulation was done in WSL V1 but I don't think the performance is good for any production workload. WSL V2 runs a real Linux OS in a "utility" VM, which shares the host's disk over virtual SMB (Samba). I doubt disk operations would be as performant in this case. I think one can get Redis working on Windows but will not get the same performance as you would expect from a similarly equipped machine running Linux. It is at best a dev scenario.

PingXie avatar Mar 31 '24 22:03 PingXie

Original reasoning http://oldblog.antirez.com/post/redis-win32-msft-patch.html

tachyons avatar Apr 01 '24 07:04 tachyons

I'm assuming Microsoft created Garnet for this reason: https://github.com/microsoft/garnet

I haven't use it personally but it looks interesting

rhuddleston avatar Apr 01 '24 16:04 rhuddleston

Yeah, let's leave this and see there is strong interest in support for windows. I think the need has dropped significantly because of WSL from when the issue was already opened.

At least, make it more friendly when compiling by msys2 and cygwin

brged avatar Apr 08 '24 02:04 brged