Ping Xie

>So I think it'd fine that clients can get the reply, then remove some fields (which we can document), then compute a hash of the rest of it. I think...

I'd think a binary filtering would be acceptable, like "topology or all". There is a straight story here IMO. Fine-grained filtering, agreed.

>What is the ultimate use case? cluster v1 is eventual consistent (if ever). whenever there is a topology change, such as adding replicas, scaling out/re-sharding, or performing rolling upgrades, there...

JSON or not is not at the core of this problem. The output of the existing `CLUSTER SHARD` is already conceptually JSON. The content is actually what is being discussed...

> Please consider dropping codespell. Its dictionary is included in typos: https://github.com/crate-ci/typos/tree/master/crates/codespell-dict I am not familiar with codespell nor spellchecker in general. Are you saying that the existing spellchecker is...

Looks like we are in general agreement with the bulk of the changes. I am going to merge this PR now to reduce the PR backlog. We can always take...

sentinel looks fine to me. I think it makes sense to default to "redis" for valkey-server's syslog-ident. Again, IMO, the ideal experience is that without the compat switch (separate discussion...

@soloestoy, I think it is a great idea to use a no-preamble AOF and I will definitely consider using it for the atomic slot migration work (https://github.com/valkey-io/valkey/issues/23). >such as the...

Got it. This is not about the full sync but the migration tool. That makes sense. I think another benefit of using no-preamble AOF in either the full sync or...

As much as I don't like it, I have to say that option 2 is safer. There is just no way to evaluate the risk of "unknown unknowns". That said,...