Ping Xie

@zuiderkwast I think JSON would be the ideal long term solution. A potential migration/upgrade strategy would be to attempting to load `nodes.json` first and on `not found` fall back to...

@madolson this change is ready. I moved shard-id behind hostname so it should be compatible with 7.0 GA. Can you please take a look? Pre 7.0: `ip:port[@cport]` 7.0: `ip:port[@cport]` or...

FYI @yossigo @oranagra - in case @madolson's bandwidth is limited recently. This PR brings native shard-id to 7.0.0 in a fully compatible way. It is ready for code review. Please...

@madolson can you please review this change when you get a chance? Thanks!

> I don't know about json, we don't have a JSON parser today in Redis and I don't think we really want to take a dependency on one. I think...

> @ushachar One of the assumptions being discussed here is that ShardIDs may not necessarily be monotonically increasing, and externally imposed. I commented on the "monotonically increasing" property on @ushachar's...

> The only other change is unit tests can now be written for cluster features so they run in the ci, in tests/unit/cluster/*, so all of your changes need to...

@hwware @zuiderkwast the shard_id change is ready for your review. This PR includes the auxiliary field support as we agreed upon in PR https://github.com/redis/redis/pull/9564 (see https://github.com/redis/redis/pull/9564#discussion_r956177431). I also refactored the...

> > The only other change is unit tests can now be written for cluster features so they run in the ci, in tests/unit/cluster/*, so all of your changes need...

>making sure replicas follow primaries correctly during slot migrations. We'll also be able to support the "empty" primary with replicas use case. Thanks @madolson! I have follow-up PRs to address...