Ping Xie

@LiiNen, I see you touched upon a few points in the logging area (and you remind me of Windows's log manager) 1. Logging levels I can see AUDIT logging being...

Thanks for the patch @WM0323! Can you consider the alternative that doesn't require vendoring mimalloc? In general, we would like to de-vendor the dependencies going forward. You can find the...

> Add support to optionally use system libraries instead of the vendored mimalloc. I see that this PR allows the user to choose between vendoring and not. Any reason to...

> > > * What happens with fragmentation on mimalloc allocator? > > > > > > Mimalloc efficiently manages fragmentation through strategies like segment reuse and object migration. However,...

Let's not merge this change just yet. We should agree on some guiding rules and make sure all log line changes are evaluated against these rules consistently. Ad hoc decisions...

> @PingXie It's a good idea to use a macro like SERVER_NAME. If we are careful, it will be easy to patch valkey to return the exact Redis log messages...

> @PingXie If we use a macro like ... > > ```c > serverLog(LL_NOTICE, SERVER_TITLE " forked for debugging eval"); > ``` > > ... then it only works in...

I would vote for "primary" and "replica". As for changes, I now think more and more that we need a "compat" knob. It can be either compile time or runtime...

> Pull off the bandaid, as they say Yes we should do it at some point but I think the timing of it falls in another *major decision* and we...

>I'm just advocating have a set plan before changes happen so it doesn't languish for an undetermined amount of time. Timing aside, I think one option, as you suggested too,...