valkey
valkey copied to clipboard
valkey-io
Fix typos and replace 'codespell' with 'typos'
Uses https://github.com/taiki-e/install-action to install https://github.com/crate-ci/typos in CI
This finds many more/different typos than https://github.com/codespell-project/codespell , while having very few false positives.
Please consider dropping codespell.
Its dictionary is included in typos: https://github.com/crate-ci/typos/tree/master/crates/codespell-dict
Please consider dropping codespell. Its dictionary is included in typos: https://github.com/crate-ci/typos/tree/master/crates/codespell-dict
I am not familiar with codespell nor spellchecker in general. Are you saying that the existing spellchecker is sufficient?
BTW, @jayvdb, all other changes LGTM. Thanks!
I did a bit of digging and can confirm typos is a superset of codespell wrt to misspelling detection capability, and finer grained configuration. codespell has a few UX features that typos doesnt have, such as an interactive TUI mode. Anyone wanting those features can continue to use codespell locally.
LGTM
How can I run typos locally? It's useful to be able to run it before pushing, instead of waiting for CI failure to find out.
See https://github.com/crate-ci/typos?tab=readme-ov-file#install
How can I run typos locally?
Just download typos, it is a single binary. Nicely fits in ~/bin/
https://github.com/crate-ci/typos/releases
Looks like we are in general agreement with the bulk of the changes. I am going to merge this PR now to reduce the PR backlog. We can always take incremental changes.