Zixuan Li

Results 238 comments of Zixuan Li

Should be fixed now. It was an error emerged from moved messages support across narrows.

Thanks! Just rebased it.

(Pushed again to fix another merge conflict.)

Regarding > …Hmm. Thinking more, actually…The current behavior for remove-star events does seem helpful, but wouldn't it also be helpful if MessageStoreImpl.handleUpdateMessageFlagsEvent acted on add-star events by making the message...

Having comments for now should be suitable.

Updated the PR. Thanks for the review!

Updated the PR. Thanks for the review! Made separate functions for one test each in action_sheet_test.dart and message_list_test.dart, and removed the extra regression test. I also squashed the later commits...

Other than "Under construction", we should also be able to remove "Subscribed to...". We can also remove "connected to" because we basically have that from the account selection page. Not...

The new design part of this is probably blocked by #915. I think we should move this to the "Launch" milestone as well.

Following up here on a recent [discovery](https://github.com/zulip/zulip-flutter/pull/924#issuecomment-2529751089) while working on this. > It might be that this means that this strategy — the strategy described in https://github.com/zulip/zulip-flutter/issues/720 — just isn't...