Zixuan Li
Zixuan Li
Regarding the noisiness of the error dialog, I think a better UX is to present a snackbar with a brief error summary and a "Show more" button that brings up...
Implemented the proposed change in a squash! commit. Before moving on to the next review, I would like to gather some feedback on this new UX ([discussion](https://chat.zulip.org/#narrow/stream/48-mobile/topic/error.20reporting/near/1931665))
Yeah, I figured that tracking if the last snack bar has expired would reduce collateral dismissal of unrelared snackbars in most cases.
Updated the PR to add a comment on the https://github.com/zulip/zulip-flutter/pull/868#discussion_r1733560511 implementation.
Pushed to rebase.
Added a commit removing a stale TODO, and squashed the two of the error reporting commits (for transient and non-transient errors) together.
The public message history from CZO can be downloaded from [this protected dropbox link](https://www.dropbox.com/scl/fi/5ugemicgz6lwrsxscqvwk/corpuses.zip?rlkey=xdje3piu5scypt3glc0n4lbrz&st=muzlmp6t&dl=0). We probably will think of a better way of reusing this in the future.
Thanks for the review! The PR has been updated.
Opened #935 for the two commits implementing the report error feature, and #936 for the other nfc commit.
Updated the PR to ignore `NetworkException` where the underlying cause is a `SocketException`, added some more documentation and cleaned up some diffs to make them easier to read. Feel free...