Zixuan Li comments

Results 238 comments of


                                            Zixuan Li

local echo (5/n): Create outbox messages on send

Will be working on a new revision to reorganize some of the implementation code with further state machine changes.

local echo (5/n): Create outbox messages on send

The PR has been updated to implement the state diagram discussed in chat: [#mobile > #F1441 Handle retry state machine @ 💬](https://chat.zulip.org/#narrow/channel/48-mobile/topic/.23F1441.20Handle.20retry.20state.20machine/near/2157168)

local echo (5/n): Create outbox messages on send

(pushed another update to make timestamps used in sendMessage testable)

local echo (5/n): Create outbox messages on send

Thanks for the review! Pushed a new revision.

local echo (5/n): Create outbox messages on send

Thanks for the reviews! I have reorganized the tests and addressed the comments, after rebasing this on top of edit message changes :tada: > What's the reason for the late...

local echo (5/n): Create outbox messages on send

Thanks for the review! Updated the PR.

local echo (5/n): Create outbox messages on send

Thanks for the review! Updated the PR.

local echo (5/n): Create outbox messages on send

In addition to the nit, added a test that targets "waiting -> waitPeriodExpired" specifically, for https://github.com/zulip/zulip-flutter/pull/1472#discussion_r2106517535, dropping the emphasis on "waiting -> waitPeriodExpired" from those two "waiting -> waitingPeriodExpired ->...