Zixuan Li comments

Results 238 comments of


                                            Zixuan Li

Support poll vote/unvote

Support poll vote/unvote

Preview | | | | - | - | | ![Screenshot from 2024-10-07 19-55-57](https://github.com/user-attachments/assets/4e22364c-95c5-48bd-b5e3-537d3341a41c) | ![Screenshot from 2024-10-07 19-57-28](https://github.com/user-attachments/assets/42530117-5f24-4656-8153-2461a69a1259) |

Support poll vote/unvote

The "pressed" UX might fit better in a separate PR. I guess we need to have a way to mark some data as "dirty" until an event comes and update...

Support poll vote/unvote

Updated the PR. The button feedback will be done in a separate PR. The current plan is to extract a common animated button widget. This should handle larger font sizes...

Support poll vote/unvote

This PR has been updated. Thanks for the review!

Support poll vote/unvote

Pushed a new revision. Thanks for the review! - Now we use vertically symmetric padding for all the option items, and limit the one-sided paddings. - This also fixed an...

Support poll vote/unvote

Thanks! The PR has been updated.

Prevent duplicate message on fetch/event race

Just ran into this again. Looks like this bug can fail a message list invariant when you unresolve the topic containing duplicate message: ``` BUG: Error handling an event: 'package:zulip/model/message_list.dart':...

JSONField(default=dict) and using .get() results in an (unexpected) error.

This bugged me too. Also, I expect `JSONField` should have a more specific type than `Any`.

local echo (5/n): Create outbox messages on send

Updated the PR! Thanks for the review. There are some pending questions mainly with regards to the state diagram and the send time limit. I introduced the new `waitPeriodExpired` state...