Zixuan Li
Zixuan Li
Thanks for the review! Updated the PR.
Moving this to integration review because these changes went through maintainer review in the original PR.
Thanks for the review @gnprice! I have addressed them and updated the PR.
Partially updated. The tests reorganization is WIP.
The tests from "Message.poll" are rewritten in two destinations. Here's a broad overview: - "new message with initial submessages" under "handleMessageEvent": Contains all the "parse poll" tests. Rewritten so that...
I have updated the PR. In this update: - added some tests back to the commit that introduces `Poll`, before moving them later; - rearrange test grouping.
Pushed a minor formatting update.
`_InsetShadowBox` was [previously](https://github.com/zulip/zulip-flutter/commit/e16251febac9b000c50969845025bc4a1b54e67a) implemented with a `SingleChildScrollView` wrapped by a `NotificationListener`. The [current implementation](https://github.com/PIG208/zulip-flutter/commit/8c2469a8276f0e6338a320f85e6d3cbf490f13a0) got a lot simpler. Because I realized that we always have some paddings such that the...
This does not implement live updates for newly starred/unstarred messages. We should able to handle #818 together with this as a post-launch follow-up.
Skipping the first 3 commits, this should be reviewable independently from #869.