Zixuan Li
Zixuan Li
Opened #1325 for the remaining cases. Follow-up issues for more complex translations: #1285 for `_errorUnimplemented` ```dart InlineSpan _errorUnimplemented(UnimplementedNode node, {required BuildContext context}) { final contentTheme = ContentTheme.of(context); final errorStyle =...
For this string, ``` lib/widgets/app.dart 184: title: 'Zulip', ``` it looks like we should use `onGenerateTitle` instead to get it localized? ```dart /// A one-line description used by the device...
Hmm, yesterday I did skim pass some of the strings you mentioned, but because I was looking for the more typical translatable strings, skipped things like the host name. In...
I ran into this issue as well when writing a custom `ExceptionGroup` class. The overloads are implementation details, but once we have a workaround, it would be great to document...
Moved the main commits to #897, so that we can get some earlier independent changes reviewed separately.
Thanks for the review @chrisbobbe! I have updated the PR. - Dropped `fromSendableNarrow` to keep the api code from depending on lib/model. - Reorganized the tests and made them shorter....
Pushed to rebase.
Thanks! I should push an update later addressing these comments.
OK, this has been updated :)
Fixed indentation in a test.