Zixuan Li

Results 238 comments of Zixuan Li

Dropped the `checkDmExpectedOp` helper because the `TypingOp.toJson` is already tested with the typing status for topic tests. Also revised the wording of some tests.

Thanks! Pushed an update to the last commit.

Switched to a different implementation for the compose box updates.

Thanks for the review! I wasn't clear about the status of the PR because I didn't post a comment after the pushes yesterday. Just worked on some improvements and addressed...

Updated the PR. Thanks for the review!

Thanks. I restored the simpler synchronous API (while returning the futures in private helpers instead of `unawaited`'ing them) and left a comment on the `async.elapse` discussion. Should be ready for...

This hasn't addressed everything yet. I will push another update later today. The current revision shows the general approach to tracking other types of composing activities. I think the later...

Created #1033 as a follow-up, and left the app lifecycle change here with the main implementation. Thanks for the review! This is ready now.

Thanks for the review! I have updated the PR addressing the comments. Note that I mentioned a minor issue in [this discussion on `composing` and `_focusChanged`](https://chat.zulip.org/#narrow/channel/243-mobile-team/topic/PR.20.23F897.3A.20TextEditingValue.20and.20keyboard.20status), which is not resolved...