Zixuan Li

Results 238 comments of Zixuan Li

Thanks for the feedback! Dropped the last commit and previous changes relevant to the tests. A new group of tests is now responsible for testing the error reporting feature.

Thanks! Ready for review now.

Thanks for the PR! Left some comments.

Comparisons: | Collapsed | Expanded | | --- | --- | | ![1000013422](https://github.com/zulip/zulip-flutter/assets/39874143/dd559442-7f13-41b4-b917-27b8ba299bbd) | ![1000013427](https://github.com/zulip/zulip-flutter/assets/39874143/4177048e-8f70-4a47-9b48-ee21c3b5ece8) | ![1000013420](https://github.com/zulip/zulip-flutter/assets/39874143/c7ac9ccf-56ac-42ab-8e62-a63a3e58f13b) | ![1000013428](https://github.com/zulip/zulip-flutter/assets/39874143/d4c729a5-4769-47f4-b55b-95a47abf7095)

The appearances of the markers can be checked in the comparisons table above. Incorporating @chrisbobbe 's [comment](https://github.com/zulip/zulip-flutter/pull/762#discussion_r1667193221), we animate the marker from the start state to the end state as...

Rebased since #762 has been merged. We will need to get back to this later to investigate alternatives to `LayoutBuilder`.

Yeah, this is not ready for review yet, but I will let you know once it is.

The referenced draft seems to be https://github.com/gnprice/zulip-flutter/tree/dev-retry. I can pick this up to work on #555.

I think detailed poll-failure feedback is valuable for unforeseen errors. Going ahead with the linear indicator for #465, most common transient errors ([unless they persist](https://github.com/zulip/zulip-flutter/blob/1964388e71f60015af831d5cd04b82a07434ccd6/lib/model/store.dart#L780)) do not need a toast....

Because our compose box is a part of the body on the Scaffold, Flutter's SnackBar does not know to avoid blocking it. Normally if there is a `bottomNavigationBar` (e.g. in...