Zixuan Li
Zixuan Li
Read through the changes and left some comments mostly for style and formatting. Thanks for the revision! The test changes look clean now; I noticed some changes that probably belongs...
Looks good. Thanks! Moving this to Greg's review.
I realized that it is possible to use adb over Wi-Fi. Not sure if it is feasible leave my debug build that way while I'm home, but it sure sounds...
A question to be answered: how do we determine if an error is transient? Currently we handle 3 classes of errors in `UpdateMachine`: 1. `ZulipApiException`: The event queue is lost....
For non-transient errors, we will probably show a modal instead.
The PR has been updated. Thanks for the review! I'm not entirely sure about the quality of the translation strings. These messages will appear more technical at the current stage...
Updated the PR to avoid wrapping `test` calls in `checkRetry`.
Updated the PR to adjust comments on `lib/log.dart` and made dialog title a parameter. I also tweaked the formatting and made some other minor improvements.
This update modifies the translation strings to include the realm URL in error messages.
Thanks for the comments. This should be ready for review again!