KevinOConnor

Results 442 comments of KevinOConnor

As mentioned previously, I've "mocked up" some trsync.c code for verifying sensors remain active. It is at: https://github.com/KevinOConnor/klipper-dev/tree/work-trsync-20250411 I'm not sure using the trsync "report timer" mechanism is the best...

Thanks. I rebased and committed this PR. I made some small modifications to the commit messages (no code changes) and merged as commits cb0c38f7, 42c9031c, 69507a03, 3dbac01e, b3e894f2, f6d878a8, and...

I corrected the comma/semicolon issue (commit 13321ce2). Thanks. I'm not sure about making the comment changes in this PR. At this point I think I'd prefer to hold all the...

Thanks. In general it seems fine to me. I have some questions and a few comments. I am curious how you are using this support. What machines are you using...

FWIW, the latest version of usb_canbus.c does implement a "discarding mode" if the canbus freezes - see `src/generic/usb_canbus.c:try_canmsg_send()`. -Kevin

Thanks for working on this. For what it is worth, I'm not sure our audience will immediately know what "bookworm" and "bullseye" are. Can we just change to the new...

Thanks for working on this. FWIW, I'd prefer not to add additional system installation scripts to the Klipper repo - it's too much of an ongoing maintenance burden. I'm not...

Thanks for working on this. I agree it would be useful to set the "usb to canbus bridge" frequency from Linux instead of from "make menuconfig". This change does have...

Thanks. In general it seems fine to me. There were some recent changes to the Kconfig file (doing something similar) so this PR will need to be rebased to the...