klipper icon indicating copy to clipboard operation
klipper copied to clipboard

resonance_tester: Fix chips selection, add accel_per_hz selection

Open MRX8024 opened this issue 1 year ago • 2 comments

-The current code does not have the option to "live" select a non-adxl345 chips when running TEST_RESONANCES, since it adds the adxl prefix by default. -Added the ability to "live" select accel_per_hz when running TEST_RESONANCES. -Minor fixes in the documentation.

Signed-off-by: Maksim Bolgov [email protected]

MRX8024 avatar Oct 30 '24 22:10 MRX8024

Every commit is expected to have a sign-off line. PR on the other hand can just have a basic description, arguing, and description of a problem: why it is a problem and how you are trying to solve it.

Also, take a look at: https://www.klipper3d.org/CONTRIBUTING.html Specifically the commit format.

Thanks.

nefelim4ag avatar Oct 31 '24 19:10 nefelim4ag

Thanks for the tip, I think I fixed the formatting of the commits

MRX8024 avatar Oct 31 '24 23:10 MRX8024

Thanks. I think this makes sense. However, given that this is a not a backwards-compatible change, I think it should be mentioned in docs/Config_Changes.md that the CHIPS= parameter for TEST_RESONANCES and SHAPER_CALIBRATE commands must specify the full accelerometer name(s).

dmbutyugin avatar Nov 11 '24 20:11 dmbutyugin

the full accelerometer name(s).

Do you want me to add a straight CHIPS=<full_chip_name>, or just description? The doc already mentions: "for example CHIPS="adxl345, adxl345 rpi"". Thanks

MRX8024 avatar Nov 11 '24 22:11 MRX8024

I think the G-Codes documentation is OK already. But since this is a change that will break any existing usages of CHIPS parameter, it is better to document this in docs/Config_Changes.md (it says 'config', however breaking gcode changes are also documented there).

dmbutyugin avatar Nov 11 '24 22:11 dmbutyugin

Thanks!

dmbutyugin avatar Nov 12 '24 18:11 dmbutyugin

Thanks.

-Kevin

KevinOConnor avatar Nov 13 '24 00:11 KevinOConnor