KevinOConnor
KevinOConnor
Thanks. From the conversation at https://klipper.discourse.group/t/make-the-api-listens-to-a-tcp-socket/21939/13 it seems there is some concern from some of the other long-term contributors (eg, security, duplication with moonraker, limited audience). I'd be inclined to...
We can certainly update these files, but I think we should have a use-case for it first. That is, if we're adding some new chip that needs the later version...
As far as I am aware, the existing code is correct. (That is, it will faithfully take a requested `run_current` and program the tmc registers to meet that `run_current` as...
> The existing code calculates the correct current, but does not use CS to do it, only globalscaler. This is unintentional, though. It is very much intentional. The code was...
> It is not mathematically possible to arrive at any value other than CS=31 in the current implementation. That is incorrect. For low `run_current` requests, the GLOBALSCALER will be set...
> Meaning that we don't get better microstepping by configuring higher CS and lower GLOBALSCALER. The tmc specs can be obtuse and confusing. However it is clear that IRUN (and...
Also, FYI, CS and IRUN are the same thing - you can see this in the tmc2660 spec: ``` CS Current scale. Scales both coil current values as taken from...
Thanks. As high-level feedback, I am leery of making such an intricate change to a common component in support of very rare hardware. The concern is that a change to...
The screenshot you provided does seem to indicate the message was successfully transmitted. (The received zero bit, that was not transmitted, after the crc information, is what an ack looks...
Thanks. However, any internal change to the code in this repo must come with some kind of user facing improvement (for those running the code in this repo). So, if...