KevinOConnor

Results 158 comments of KevinOConnor

I understand. In general, I am open to custom licensing on an individual case-by-case basis. However, I am not planning to re-license can2040 globally at this time. Cheers, -Kevin

I don't have any plans to port the code to other micro-controllers. For what it is worth, the current code is tightly integrated with the rp2040 PIO hardware, which is...

Can you provide some additional information on why you believe this is not working correctly? I did attempt to make that work (see the check in `data_state_update_eof1()` in can2040.c). Admittedly,...

> I can help you test that code path with the CANHack toolkit, which is designed to inject these conditions: Thanks. > In terms of the logic, I see you're...

I understand the intent of the "error active" state (in short, it increases the confidence that a bus message is either received by all nodes or zero nodes). Alas, I...

Thanks. Maybe @dmbutyugin or @bluesforte have comments on this? -Kevin

Thanks. On the top right hand side of this github PR page there is an "assignees" option - if you assign this PR to yourself then it'll turn off the...

Config files will need to follow the guidelines at https://www.klipper3d.org/Example_Configs.html and commits need to have a signed-off-by line https://www.klipper3d.org/CONTRIBUTING.html -Kevin

Okay, but it will be necessary to find the root cause of the error. Making changes without understanding the root cause increases the risk of introducing a regression for other...

Thanks. In general, I'm fine with adding support for additional boards like this. However, this commit adds several "ifdefs" to the code - some of which look incorrect (eg, the...