KevinOConnor

> Alright, I'm sold on a conceptual level. I'll dig into the code when I'm back at home base next week and start an initial review if @KevinOConnor is on...

Thanks, but this Klipper repo doesn't support mcus that report gd32f303 as the cpu type, and we don't add code to this repo to support external modifications. -Kevin

My rough understanding is that the gd32f303 chips are supported by Klipper - one selects an stm32f103 chip during "make menuconfig". I'm not sure what code you are running. -Kevin

Thanks. I don't think this change will work correctly though. It looks like the change will alter the homing position if one homes with the ldc1612, but it will not...

Thanks for working on this. I agree it would be good to merge this support into Klipper. I do have some comments on the changes. I like how you've split...

That completes my code review. Thanks again for working on this. If you do rebase the commits, it would help a little if you could have each commit follow the...

FYI, here is a mockup of a further generalized sos_filter.c (untested, but hopefully gives the idea): https://github.com/KevinOConnor/klipper-dev/commit/2e174e35550aaf996d907ca6ad4cdb20fed61c1a -Kevin EDIT: Actually, the python code should be using `is_init=True` - updated the...

> This is a show stopper. ... If I have to give up endstop compatibility I think the only path forward now is to wait until after you re-write homing...

There are two main internal probing interfaces: the probe command interface and the homing interface. The probe command interface is used for `PROBE` type commands (including `PROBE_ACCURACY`, `BED_MESH_CALIBRATE` and similar),...

> > Maybe just "load_cell.c" or "load_cell_tap.c"? > "load_cell_probe.c" ? Sounds okay to me. -Kevin