KevinOConnor
KevinOConnor
I'm not sure what this does, or why one would want it. Can you elaborate? Thanks, -Kevin
Okay, thanks. How about we change the "clock reference" menu so that it lists: 8Mhz crystal, 12Mhz crystal, ..., 12Mhz external clock, ..., Internal clock. That is, add options for...
Okay, thanks. However, I think maintaining the single clock reference menu would be desirable, and I think we should avoid using cryptic terms like "HSE" in the user facing Kconfig...
Thanks. We can add this, but we've given up on introducing names like "spi0e". The new scheme is to use names like "spi0_gpio4_gpio3_gpio2" - see src/stm32/spi.c for examples. Separately, I...
> or were you suggesting I just add the new spi0e bus as the new format, and leave the existing ones named as is? Introduce new using the new format....
Thanks. In general it seems fine, but I don't think we should add a new old-style "spi0e" name. The new mapping should be available solely as "spi0_gpio4_gpio3_gpio2". -Kevin
Thanks. -Kevin
Thanks. Some feedback: 1. Any change to the main Klipper repo would need to come along with some user facing functionality. We don't make changes to the main Klipper repo...
Some core issues I ran into: 1. It doesn't really make sense to "average multiple samples" unless one is using "descend until trigger". Probes that can do "scan probing" don't...
Thanks. I'm not sure I'm a good reviewer for this. @alchemyEngine - do you have any comments? -Kevin