KevinOConnor

I don't have a strong preference. If it's a "printer" config file and the macros are relevant to successfully printing on that particular printer than I can see value in...

Interesting. I'm not sure this implementation is safe though, as the PID `temperature_update()` code is called from a background thread (`serialhdl:_bg_thread()`) and I don't know what would happen if one...

Thanks. In general it seems fine to me. New documentation files should also be added to Overview.md (mentioned briefly in point 5 at https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review ). I don't think the official...

Thanks. For what it is worth though, I'm not sure this is a good idea. In particular, I'm not sure the safety checks would work the same way they do...

Thanks for working on this. > Goals: We care about the maximum duration for safety and it will be nice to reduce TTC errors and it will be nice to...

> I feel guilty about a large number of PRs. I appreciate your contributions and the research you've done on various areas of the code. Please don't feel guilty about...

Thanks, and sorry for the delay. If I understand correctly, this new module overrides the typical `G28` homing sequence with a new one that also calls `PROBE`. It some ways...

Thanks. We can certainly add a shutdown safety check for tachometers. A couple of notes on the implementation: * It's not valid to perform a safety check from the `get_status()`...

Thanks. This change seems like it would cause significant delays during probe sessions (as wait_moves() takes a long time to complete). I'm not sure I understand the problem being reported...

FYI, the probe offsets are used in the calculations for z_tilt and quad_gantry_level. So, it is important that the user specify these values correctly. We can certainly change the documentation...