KevinOConnor
KevinOConnor
Okay thanks. I was able to merge this. Unfortunately, github did something weird and the commit message got lost. Sorry about that. -Kevin
Thanks. @koonweee, @blastrock - do you have any comments? On a quick glance through this PR, it seems some of the config options change (`z_compensations` to `zx_compensations`). At a minimum...
> Could you have a look too @KevinOConnor? I think it's really your call on this. I noticed a few minor things: * We should get a bunch of people...
Okay, thanks. I'll give another couple of days just to see if there are further comments, but otherwise look to commit. -Kevin
Thanks. Could you describe the problem being solved? In what situations would a 'klippy:ready' event run a g-code command? (If there are any cases - those cases should be fixed...
The "klippy:ready" callback is internal to the Klipper code (that is, only relevant to code in this github repo). If you've found some way to create an error in the...
My vague recollection is that some of the ready callbacks may inspect the current state and thus we need to transition prior to invoking the callbacks. That said, I don't...
Klipper does not have a plugin system. Any changes to the repo (including adding of files) is a modification of the code. From what you describe, it does sound like...
Thanks. Some answers to your questions: 1. Yes. It shouldn't call `pause()` and shouldn't call anything that can raise an error ( see the short blurb at https://www.klipper3d.org/Code_Overview.html#adding-a-host-module ). 2....