KevinOConnor

Thanks. Seems interesting. I have some high-level feedback: 1. This PR would need to pass the regression test cases before we could merge. 2. The PR would need to include...

> Most of the time it will work fine, however Linux may sometimes decide that a read needs to be a full syscall rather than happening in userspace, which can...

Thanks. We can certainly commit this change. For what it is worth, though, I did not understand the documentation for this new parameter. As a user, when would I set...

Thanks. I guess the main question is - does the adxl345 actually work well in i2c mode? When that chip is in i2c mode it is severely limited in the...

Thanks for working on this. What is the current status of this PR? Is there a consensus on a documentation change? -Kevin

Interesting, thanks. I agree it is worthwhile to change the code to avoid this problem. I agree with Arksine in that I'm unsure about changing FLASH_APPLICATION_ADDRESS and about introducing a...

Thanks. I appreciate you taking the time to review and make fixes to the documentation. As high-level feedback, there are a lot of changes in this PR and a handful...

Thanks. I don't know enough about these printers to review this PR. Maybe @dmbutyugin can do a review. It does seem a little odd that an option is needed to...

Thanks. I'm not sure about this change, as there isn't a simple mapping between ihold/irun and amps. I fear it could be confusing to users that a dump of the...

For what it is worth, perhaps an alternative would be for DUMP_TMC to report the power settings (as SET_TMC_CURRENT already does). Or perhaps the documentation could make it more clear...