KevinOConnor
KevinOConnor
> By "different descriptions", do you mean both peak-to-peak and RMS? I mean, for example, that the IRUN field may have a value of 5, but that may translate to...
Thanks. I think it would be useful to add support for lis3dh. Some comments: 1. As others have mentioned, I think it would be useful to merge this into the...
Thanks. @SteveGotthardt - can you review this change? In addition to Steve's review, I have a couple of comments: 1. The new config file added in this PR should follow...
Thanks. I have an additional question - is there a reason why a Kconfig option has been added? Could we just always define all 100 pins even if the user...
Thanks. I don't think there is an issue with adding enumerations (nor a problem with adding hard_pwm definitions). This doesn't change the hardware accesses at all - it just adds...
Thanks, it seems fine, but you should remove the existing `DECL_ENUMERATION_RANGE("pin", "PD2", GPIO('D', 2), 1);` definition (the new `PD0` definition replaces the old one). Also, please don't make the unrelated...
> PD0 and PD2 are 2 different IO pins on the MCU and different boards may use them independently. Maybe I'm missing something. There is an existing line: `DECL_ENUMERATION_RANGE("pin", "PD2",...
Thanks. A call to `toolhead.get_last_move_time()` has side effects - it flushes the lookahead queue and ensures that the "print time" advances. So, I think this change could have a subtle...
Thanks. -Kevin