KevinOConnor
KevinOConnor
Thanks. I guess I'm a little unsure on this as it isn't clear to me that there would be very many people that would set this low-level field. I wasn't...
Okay, thanks. If this is for hardware that hasn't been released yet then I think we should hold-off until that hardware is in wide circulation. (As, for example, there might...
Thanks. As high-level feedback, I'm not really sure what this code does. I don't have this hardware, so it's hard for me to review or give feedback. Perhaps you could...
Okay, thanks for the description. As high-level feedback I don't think the approach taken in this PR is ideal. I think we want to keep the stepper code related just...
> One nit - isn't the min/max positions meant to be the physical limits? Sorry, yes you are correct - the position_min/max are the maximum travel for the rail. I...
Thanks. As high-level feedback, some of these changes look fine and some I'm unsure of. It might be easier to break this up into a couple of PRs. I have...
What is the status of this PR? Is it just tracking other PRs or is there code to be reviewed here? Cheers, -Kevin
The Klipper github issue tracker is no longer used for any purpose. None of the active developers are reading or tracking any of the messages here. If there is an...
Thanks. Is this sensor based on the ldc1612 chip? There has been some work done on that chip at #6536 (and #6537). My high-level feedback is that I think we...
Thanks. I'm not very familiar with this LED type. How does it differ from the existing "dotstar" module? -Kevin