KevinOConnor

Results 442 comments of KevinOConnor

I would have thought a hysteresis of 1 degree would be fine. It's just to avoid noise on the thermistor right? -Kevin

Okay, thanks. That is interesting, and I've not seen that report before. All of my extruders will cool at a lower rate when the fan is turned off, but do...

Thanks. Alas, I haven't been able to get time to look at this further. One high-level comment I have is that I wonder if a more generic fan speed system...

Thanks. What board is this needed on? In general it seems fine but commits need to have a signed-off-by line - see: https://www.klipper3d.org/CONTRIBUTING.html -Kevin

Thanks. I don't think I'm in a good position to review this PR. Maybe @Arksine or @JamesH1978 can help. -Kevin

Thanks. What is the current status of this PR? -Kevin

Thanks, but commits need to have a signed-off-by line - see: https://www.klipper3d.org/CONTRIBUTING.html Also, we've stopped using names like "spi2b" for new entries. New entries should take the form "BUS_PINS_spi2_PA10_PA11_PF1". -Kevin

Thanks. What is the status of this PR? It seems like this functionality isn't needed because systemd can already perform the required functionality? -Kevin

Thanks. The convention is to introduce new `generic-xxx.cfg` files to support a new type of board. The common `sample-aliases.cfg` shouldn't be modified. Separately, commits need to have a signed-off-by line...

Also see: https://www.klipper3d.org/Example_Configs.html -Kevin