KevinOConnor

Results 442 comments of KevinOConnor

idex_modes: Bugfix for kinematic position calculation.

Thanks. -Kevin

idex_modes: Bugfix for kinematic position calculation.

> My expectation was that you had a Klipper fork with your own changes applied, such that you'd have a direct control over the changes from the mainline, especially the...

serial_bridge: Add serial bridge module for communication with UART peripherals

Thanks. As high-level feedback, I think it would be useful to add support for forwarding an mcu serial port back to the host software. I do have a few comments...

Fix building for "Linux Process" in non-FHS environments

Thanks. It seems fine to me. Could you split the line in the Makefile so it does not exceed 80 characters though? -Kevin

Fix building for "Linux Process" in non-FHS environments

Thanks. -Kevin

fan: Support multiple printer fans

Thanks. In general it seems fine to me. I'd prefer to see some comments from users of this functionality as well though (I don't own hardware that would utilize this...

Update Measuring_Resonances.md

Thanks. Looks fine to me. I'll wait a few days to see if @dmbutyugin has any comments. -Kevin

Update Measuring_Resonances.md

Okay, thanks. If there are no further comments I'll look to commit in a few days. -Kevin

Update Measuring_Resonances.md

Thanks. -Kevin

[WIP] custom_component: allow to load python components natively

I started a discussion on something similar at https://klipper.discourse.group/t/possible-klipper-plugins-instead-of-macros/9819 . It would be important for me that a "plugin" system have a well understood and stable API. Otherwise, I fear...