KevinOConnor
KevinOConnor
Thanks. As high-level feedback the change seems fine to me. I do have a couple of minor comments. I'm not sure about adding a new CLEAR_KINEMATIC_POSITION command. I wonder if...
Also, to your earlier question - I don't think the code should call `printer.send_event("toolhead:set_position")` on a clearing of homing state. That event is intended to inform the gcode parsing code...
Thanks. I apologize for the delay in responding. Unfortunately, this PR appears to be a "rewrite" of the existing firmware_retract module. That is, there is a single commit that makes...
Thanks for the feedback. I understand the concerns. I agree that zhop functionality seems useful and seems like it would make sense to have in Klipper. I feel there are...
Thanks. I think we need to figure out some long-term direction plans - as described at https://klipper.discourse.group/t/possible-klipper-plugins-instead-of-macros/9819 and https://klipper.discourse.group/t/new-submission-process-for-feature-enhancements/9818/11 . Hopefully we'll have consolidated on a plan going forward in...
Yes, I have studied the Haasoscope schematic. Unfortunately, if I model the opamp circuit using Ohm's law and Kirchhoff's law, the predictions for DAC settings do not match the actual...
A transmit message notification should only occur after the message contents have been fully confirmed on the CANRX line (including header, body, crc, ack, and eof bits). So, hard to...
Thanks. I'm not sure what the "sensor reset" stuff is. There were a bunch of stuff discussed above, but putting aside various code commentary, I'd say only the following are...
Thanks. I can only give high-level comments as I'm not familiar with the details of these sensors - so take my comments with "a grain of salt". > I don't...
> I think an axis moving without a functioning endstop counts as a SHUTDOWN "for safety issues", this is just like a thermistor becoming unplugged. A bit off topic here,...