FidelityFX-SDK

FidelityFX-SDK copied to clipboard

FrameinterpolationSwapchainDX12 doesn't support BGRA8 swapchain/backbuffer formats

3

This is half bug, half feature request. When a BGRA8 swap chain desc is passed to `ffxCreateFrameinterpolationSwapchainDX12`, `GetFfxSurfaceFormat` or `ffxGetSurfaceFormatDX12` are called at some point and trip an assertion due...

Nukem9

Very Coooool!!!!

4

What are the cmake flags do I use to build this and examples on linux + vulkan?

bigdimboom

Game motion vectors exceeding [-1.0, 1.0] in the `ReconstructAndDilate` pass will likely cause infinite loops in subsequent render passes. `computeOpticalFlowVectorField` is one example. A workaround is to [clamp fDilatedMotionVector](https://github.com/GPUOpen-LibrariesAndSDKs/FidelityFX-SDK/blob/a0632abf1350bb64c098573d84c42f053f053a6e/sdk/include/FidelityFX/gpu/fsr2/ffx_fsr2_reconstruct_dilated_velocity_and_previous_depth.h#L134) between...

Nukem9

How do I know maxContexts for ffxGetScratchMemorySizeDX12?

1

For example, for FSR3Upscaler. Maybe: ``` typedef enum Fsr3BackendTypes : uint32_t { FSR3_BACKEND_SHARED_RESOURCES, FSR3_BACKEND_UPSCALING, FSR3_BACKEND_FRAME_INTERPOLATION, FSR3_BACKEND_COUNT } Fsr3BackendTypes; ``` ``` int effectCounts[] = {1, 1, 2}; for (auto i =...

ohmaya

Fsx

2

Edgardwifi

Create msbuild.yml

2

Edgardwifi

Is pixlib.lib mandatory?

1

I was integrating https://github.com/GPUOpen-LibrariesAndSDKs/FidelityFX-SDK/tree/release-FSR3-3.0.3/sdk, by: ``` FetchContent_Declare( GIT_REPOSITORY ... .git SOURCE_SUBDIR sdk ``` Hopefully, this does not process content above /sdk. 1 of my engine's RHI DX12 projects contains a...

ohmaya

Macro doesn't expand correctly in CLANG / GCC

1

The macro `#define EAN(pass) pass, L#pass` found here https://github.com/GPUOpen-LibrariesAndSDKs/FidelityFX-SDK/blob/a0632abf1350bb64c098573d84c42f053f053a6e/sdk/src/components/opticalflow/ffx_opticalflow.cpp#L220 doesn't expand correctly in CLANG or GCC. Can we please change it to `#define EAN(pass) pass, L###pass`? This should work on...

VeganPower

https://github.com/GPUOpen-LibrariesAndSDKs/FidelityFX-SDK/blob/release-FSR3-3.0.3/sdk/src/components/fsr3/CMakeLists.txt#L34 ``` file(GLOB PUBLIC_SOURCES "${FFX_HOST_PATH}/fsr3/*.h" "${FFX_HOST_PATH}/fsr3/*.cpp") list(APPEND PUBLIC_SOURCES ${FFX_PUBLIC_SOURCES}) ``` The only fsr3-related (not fsr3upscaler) file in sdk\include\FidelityFX\host is ffx_fsr3.h, which could need to be included in public_source.

ohmaya

Which folder should I specify for add_subdirectory > binary_dir?

1

Looks like if I want to include FidelityFX with CMake, it is possible to use [add_subdirectory](https://cmake.org/cmake/help/latest/command/add_subdirectory.html#command:add_subdirectory). source_dir should be FidelityFX-SDK\sdk. Looks like 2 choices for binary_dir: - FidelityFX-SDK\sdk\build - PROJECT_BINARY_DIR...

ohmaya