FidelityFX-SDK icon indicating copy to clipboard operation
FidelityFX-SDK copied to clipboard

Macro doesn't expand correctly in CLANG / GCC

Open VeganPower opened this issue 1 year ago • 1 comments

The macro #define EAN(pass) pass, L#pass found here https://github.com/GPUOpen-LibrariesAndSDKs/FidelityFX-SDK/blob/a0632abf1350bb64c098573d84c42f053f053a6e/sdk/src/components/opticalflow/ffx_opticalflow.cpp#L220

doesn't expand correctly in CLANG or GCC.

Can we please change it to #define EAN(pass) pass, L###pass? This should work on all platforms.

Thanks.

VeganPower avatar Dec 19 '23 11:12 VeganPower

Similar to the other issue using size_t used in line 740 of ffx_types requires to include stddef.h or the program won't compile on CLANG.

https://github.com/GPUOpen-LibrariesAndSDKs/FidelityFX-SDK/blob/a0632abf1350bb64c098573d84c42f053f053a6e/sdk/include/FidelityFX/host/ffx_types.h#L740

VeganPower avatar Dec 19 '23 17:12 VeganPower