Yuri Rubinsky
Yuri Rubinsky
@tomspilman I guess this PR is good and could be final jewel in the crown of the fresh MonoGame 3.5.
I asked about this and skinning PR in twitter - they keep silence...
Commits needs to be squashed (https://docs.godotengine.org/en/latest/contributing/workflow/pr_workflow.html#modifying-a-pull-request).
Thanks for your contribution. You need to squash the commits as required by our pipeline (see https://docs.godotengine.org/en/latest/community/contributing/pr_workflow.html).
I see the noticeable and long lag second after zooming is performed, which is very annoying.
> Should I try to squash the branch or will that be done when merging? Yes, you should.
Would you like to change the existed `VisualShaderNodeTextureParameterTriplanar` to support this by default or (if its break compatibility) by setting a flag?
> @Chaosus Anything to add/change? Nothing, I think it's fine in its state. Thanks for implementing this!
@Lielay9 Seems like you overrode the commit name - please make it meaningful (like `Add a function Camera3D::get_frustum_plane_intersection()`).
Superseded by https://github.com/godotengine/godot/pull/91702