Yuri Rubinsky
Yuri Rubinsky
@Lielay9 Sorry if I wrongly thought that you abandoned this PR, if you will to continue I will close mine and reopen this.
> Pressed "Add Node...", dragged and dropped ColorConstant to the graph, I get those two errors: > > ERROR: Condition "!get_viewport()->gui_is_dragging()" is true. > at: set_drag_preview (./scene/gui/control.cpp:1965) @akien-mga The first...
Great!, but the commits need to be squashed (always).
> Thank you.. I am trying to squash them but it says there's a merge amongst the commits.. so now I don't know how to squash them or remove the...
If you stuck completely - you can close this PR and recreate it (nothing bad in it, this is common problem across newcomers).
Guess this line could be changed too (after https://github.com/godotengine/godot/commit/d8aa2c65a9f857e86d0c1fc1cc6b95b8ccf23099): https://github.com/godotengine/godot/blob/d8aa2c65a9f857e86d0c1fc1cc6b95b8ccf23099/editor/connections_dialog.cpp#L285
Thanks for your PR, CI failed, use the clang-format tool to prevent such errors (just an advice) (see https://docs.godotengine.org/en/latest/contributing/development/code_style_guidelines.html#using-clang-format-locally). Also, commits need to be squashed (see https://docs.godotengine.org/en/latest/contributing/workflow/pr_workflow.html#modifying-a-pull-request).
~I suspect that algorithm should be faster on open-space with low amount of obstacles rather than high.~ Nvm, it's really slower, strange... The other assumption that it currently uses a...
> Doesn't this break compatibility with 4.2? Or is auto expansion new of 4.3? This exists in 4.2 but working incorrectly for this node, and these sub-ports should not be...
I think It's fixed in https://github.com/godotengine/godot/pull/80555, that PR may be back ported to 4.1.x in order to fix this.