godot icon indicating copy to clipboard operation
godot copied to clipboard

Support shader preprocessor concatenation symbol

Open JohanAR opened this issue 2 years ago • 1 comments

JohanAR avatar Mar 10 '23 17:03 JohanAR

CC @bitsawer

clayjohn avatar Mar 10 '23 17:03 clayjohn

Remember to document this change in https://docs.godotengine.org/en/latest/tutorials/shaders/shader_reference/shader_preprocessor.html :slightly_smiling_face:

You can open a draft pull request on godot-docs' master branch now – no need to wait for this PR being merged.

Calinou avatar Mar 13 '23 17:03 Calinou

Docs PR https://github.com/godotengine/godot-docs/pull/6979

JohanAR avatar Mar 14 '23 08:03 JohanAR

Looks good to me after the changes. Tested with my own projects and tests, seems to work as expected. I'll add those tests to my preprocessor test suite and try to eventually make a public PR for it once I have some extra time.

@Chaosus might still want to take a look and give the final approval.

bitsawer avatar Apr 16 '23 15:04 bitsawer

Tested and it works fine for me - just add the missing dots to the commentaries.

Thanks! I'm not that used to working with github's web UI, but I think I got all the suggestions. Should I try to squash the branch or will that be done when merging?

JohanAR avatar Aug 07 '23 15:08 JohanAR

Should I try to squash the branch or will that be done when merging?

Yes, you should.

Chaosus avatar Aug 07 '23 15:08 Chaosus

Thanks!

akien-mga avatar Aug 08 '23 15:08 akien-mga