Duo Zhang

Results 366 comments of Duo Zhang

> We've discussed this with @wchevreuil , the only sane ways seems to be removing any code that relies on serializing arbitrary multigigabyte internal objects (BucketCache) into JSON with reflection-happy...

I think @stoty proposed a more general way for solving the problem that we should not print all the things in BucketCache on our web UI... For solving the problem...

@stoty Are you OK with the current approach for fixing TestBucketCache first?

> This PR is not correct still and more complicated than I thought. > > Need second thoughts. I think at least the code can fix one concurrency problem, are...

Please use shaded version of guava classes? Thanks.

Any updates here? @chandrasekhar-188k Thanks.

Please address the error prone error?

ScanMetrics is IA.Public, so we can not hide the public fields without deprecation cycle...

Took a quick look, I still could not fully understand the mechanism here... Please give me some time for a detailed look before merging... Thanks.

The intention here is that, in AsyncTableImpl, we will always call any callbacks in a thread pool, in order to prevent blocking operations in callbacks blocking the system thread(like netty...