Duo Zhang comments

Results 364 comments of


                                            Duo Zhang

好的，我看一下，感谢~

The upper layer will not call abortWriter when closeWriter throws exception? Strange...

@anmolnar You can merge this by yourself since you are a committer now.

Let me see if the copilot can give some feedbacks since this is a very big change...

Ping @bbeaudreault @rmdmattingly PTAL at this? I'm not familiar with the backup code and I think this is a blocker for the 2.6.1 release?

Please open a PR against branch-2 too? I will merge them at once. Thanks for the fixing! @ciacono @aaronbee

Is it ready to be merged?

+1 with stoty, is this more like a test problem or an actual problem in main code?

We do not want to serialize private fields? Really? I think most POJOs are private fields with getter and setter?

So how do we plan to fix this?