Duo Zhang comments

Results 364 comments of


                                            Duo Zhang

HBASE-27221 Bump spotless version to 2.24.1

Also fixed a typo in comment

HBASE-26926 VerifyReplication should use region startKey to check PeerTable

Is the test failure related? And minding explain more about how to choose the startRow and stopRow in this tool? Thanks.

HBASE-26583 Make StatisticThread alternative in BucketCache

Please rebase and fix the checkstyle issue? Thanks.

HBASE-27252 Clean up error-prone findings in hbase-it

Let me close this PR by a commit with the above fixes.

HBASE-26955 Improvement of the pause time between retries in Rpc caller

In general I do not think we should use the same logic in RemoteProcedureResultReporter. At region server side we know the procedure result is very important so we sould try...

HBASE-26555 Fix findbugs/spotbugs findings

> Each module has its own commit in the PR branch @Apache9 . I think that is the best we can do as far as keeping each review item small....

Missing "'s" in README

Thanks for contributing. HBase uses jira for tracking issues, so please register here https://issues.apache.org/jira And open an issue for HBase about this change. Thanks.

HBASE-23285 LogCleaner should not delete empty oldWALs/rs directories…

In general I think we should delete the empty oldWALs/rs directories in LogCleaner, otherwise the directories for dead region server will leave there forever. We should catch the exception when...

HBASE-21521 Expose master startup status via web UI

Any progress here?

HBASE-27212 Implement a new table based replication queue storage and…

Finally I could pass compilation. In this PR I tried to make claimQueue basically work so at least the failover UTs without replication can pass, and I also we could...