hbase icon indicating copy to clipboard operation
hbase copied to clipboard

HBASE-28770: Support partial results in AggregateImplementation and AsyncAggregationClient

Open charlesconnell opened this issue 1 year ago • 6 comments

Currently there is a gap in the coverage of HBase's quota-based workload throttling. Requests sent by [Async]AggregationClient reach AggregateImplementation. This then executes Scans in a way that bypasses the quota system. We see issues with this at Hubspot where clusters suffer under this load and we don't have a good way to protect them.

In this PR I'm teaching AggregateImplementation to optionally stop scanning when a throttle is violated, and send back just the results it has accumulated so far. In addition, it will send back a row key to AsyncAggregationClient. When the client gets a response with a row key, it will sleep in order to satisfy the throttle, and then send a new request with a scan starting at that row key. This will have the effect of continuing the work where the last request stopped.

This feature will be unconditionally enabled by AsyncAggregationClient once this ticket is finished. AggregateImplementation will not assume that clients support partial results, however, so it can keep supporting older clients. For clients that do not support partial results, throttles will not be respecting, and results will always be complete.

charlesconnell avatar Aug 18 '24 18:08 charlesconnell

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 28s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+0 :ok: buf 0m 0s buf was not available.
+0 :ok: buf 0m 0s buf was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 53s master passed
+1 :green_heart: compile 4m 32s master passed
+1 :green_heart: checkstyle 1m 4s master passed
+1 :green_heart: spotbugs 4m 41s master passed
+1 :green_heart: spotless 0m 42s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 44s the patch passed
+1 :green_heart: compile 4m 30s the patch passed
+1 :green_heart: cc 4m 30s the patch passed
+1 :green_heart: javac 4m 30s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 0m 14s /results-checkstyle-hbase-client.txt hbase-client: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)
-1 :x: spotbugs 0m 47s /new-spotbugs-hbase-client.html hbase-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 :green_heart: hadoopcheck 10m 39s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart: hbaseprotoc 1m 39s the patch passed
+1 :green_heart: spotless 0m 40s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 33s The patch does not generate ASF License warnings.
48m 46s
Reason Tests
SpotBugs module:hbase-client
Load of known null value in org.apache.hadoop.hbase.client.RawAsyncTableImpl.onLocateComplete(Function, ServiceCaller, AsyncTable$PartialResultCoprocessorCallback, List, byte[], boolean, AtomicBoolean, AtomicInteger, HRegionLocation, Throwable) At RawAsyncTableImpl.java:in org.apache.hadoop.hbase.client.RawAsyncTableImpl.onLocateComplete(Function, ServiceCaller, AsyncTable$PartialResultCoprocessorCallback, List, byte[], boolean, AtomicBoolean, AtomicInteger, HRegionLocation, Throwable) At RawAsyncTableImpl.java:[line 822]
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6167
JIRA Issue HBASE-28770
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc
uname Linux e66195f6a684 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / c08afe1904f1ccdf91b6e98e113b5693865c5c1e
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 86 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-endpoint U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/1/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Aug 18 '24 19:08 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 27s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 13s master passed
+1 :green_heart: compile 2m 8s master passed
+1 :green_heart: javadoc 1m 4s master passed
+1 :green_heart: shadedjars 5m 47s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 2s the patch passed
+1 :green_heart: compile 2m 6s the patch passed
+1 :green_heart: javac 2m 6s the patch passed
+1 :green_heart: javadoc 1m 0s the patch passed
+1 :green_heart: shadedjars 5m 47s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 0m 33s hbase-protocol-shaded in the patch passed.
+1 :green_heart: unit 1m 35s hbase-client in the patch passed.
+1 :green_heart: unit 208m 53s hbase-server in the patch passed.
+1 :green_heart: unit 3m 24s hbase-endpoint in the patch passed.
243m 47s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6167
JIRA Issue HBASE-28770
Optional Tests javac javadoc unit compile shadedjars
uname Linux d50027a35903 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / c08afe1904f1ccdf91b6e98e113b5693865c5c1e
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/1/testReport/
Max. process+thread count 4849 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-endpoint U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Aug 18 '24 22:08 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 40s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+0 :ok: buf 0m 0s buf was not available.
+0 :ok: buf 0m 0s buf was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 59s master passed
+1 :green_heart: compile 4m 32s master passed
+1 :green_heart: checkstyle 1m 1s master passed
+1 :green_heart: spotbugs 4m 37s master passed
-1 :x: spotless 0m 43s branch has 1 errors when running spotless:check, run spotless:apply to fix.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 46s the patch passed
+1 :green_heart: compile 4m 32s the patch passed
+1 :green_heart: cc 4m 32s the patch passed
+1 :green_heart: javac 4m 32s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 1m 1s the patch passed
+1 :green_heart: spotbugs 5m 7s the patch passed
+1 :green_heart: hadoopcheck 10m 34s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart: hbaseprotoc 1m 42s the patch passed
-1 :x: spotless 0m 17s patch has 63 errors when running spotless:check, run spotless:apply to fix.
_ Other Tests _
+1 :green_heart: asflicense 0m 33s The patch does not generate ASF License warnings.
48m 27s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6167
JIRA Issue HBASE-28770
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc
uname Linux 65b1f8b6e0e2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f4d984bb35441b07cad0aad7a75c7ea452baeb75
Default Java Eclipse Adoptium-17.0.11+9
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/2/artifact/yetus-general-check/output/branch-spotless.txt
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/2/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count 85 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-endpoint U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/2/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Aug 19 '24 15:08 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 39s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 4s master passed
+1 :green_heart: compile 2m 18s master passed
+1 :green_heart: javadoc 1m 10s master passed
+1 :green_heart: shadedjars 5m 18s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 5s the patch passed
+1 :green_heart: compile 2m 19s the patch passed
+1 :green_heart: javac 2m 19s the patch passed
+1 :green_heart: javadoc 1m 10s the patch passed
+1 :green_heart: shadedjars 5m 20s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 0m 37s hbase-protocol-shaded in the patch passed.
+1 :green_heart: unit 1m 35s hbase-client in the patch passed.
+1 :green_heart: unit 221m 41s hbase-server in the patch passed.
+1 :green_heart: unit 3m 34s hbase-endpoint in the patch passed.
257m 2s
Subsystem Report/Notes
Docker ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6167
JIRA Issue HBASE-28770
Optional Tests javac javadoc unit compile shadedjars
uname Linux 98d86c235770 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f4d984bb35441b07cad0aad7a75c7ea452baeb75
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/2/testReport/
Max. process+thread count 4791 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-endpoint U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/2/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Aug 19 '24 19:08 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 25s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+0 :ok: buf 0m 0s buf was not available.
+0 :ok: buf 0m 0s buf was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 47s master passed
+1 :green_heart: compile 4m 30s master passed
+1 :green_heart: checkstyle 1m 2s master passed
+1 :green_heart: spotbugs 4m 35s master passed
+1 :green_heart: spotless 0m 40s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 47s the patch passed
+1 :green_heart: compile 4m 31s the patch passed
+1 :green_heart: cc 4m 31s the patch passed
+1 :green_heart: javac 4m 31s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 1m 1s the patch passed
+1 :green_heart: spotbugs 5m 13s the patch passed
+1 :green_heart: hadoopcheck 10m 22s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart: hbaseprotoc 1m 41s the patch passed
+1 :green_heart: spotless 0m 41s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 32s The patch does not generate ASF License warnings.
48m 13s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6167
JIRA Issue HBASE-28770
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc
uname Linux f7b81a8b67bc 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 3aaddade55d6bd52992d0dc466a4fbc28e702f51
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 87 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-endpoint U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/3/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Aug 19 '24 20:08 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 28s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 12s master passed
+1 :green_heart: compile 2m 9s master passed
+1 :green_heart: javadoc 1m 3s master passed
+1 :green_heart: shadedjars 5m 49s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 1s the patch passed
+1 :green_heart: compile 2m 8s the patch passed
+1 :green_heart: javac 2m 8s the patch passed
+1 :green_heart: javadoc 1m 1s the patch passed
+1 :green_heart: shadedjars 5m 46s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 0m 34s hbase-protocol-shaded in the patch passed.
+1 :green_heart: unit 1m 36s hbase-client in the patch passed.
+1 :green_heart: unit 209m 29s hbase-server in the patch passed.
+1 :green_heart: unit 4m 0s hbase-endpoint in the patch passed.
245m 46s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6167
JIRA Issue HBASE-28770
Optional Tests javac javadoc unit compile shadedjars
uname Linux 7bc05e1db629 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 3aaddade55d6bd52992d0dc466a4fbc28e702f51
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/3/testReport/
Max. process+thread count 5399 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-endpoint U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/3/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Aug 19 '24 23:08 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 39s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+0 :ok: buf 0m 0s buf was not available.
+0 :ok: buf 0m 0s buf was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 :ok: mvndep 0m 39s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 34s master passed
+1 :green_heart: compile 5m 34s master passed
+1 :green_heart: checkstyle 1m 19s master passed
+1 :green_heart: spotbugs 4m 52s master passed
+1 :green_heart: spotless 0m 41s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 44s the patch passed
+1 :green_heart: compile 4m 33s the patch passed
+1 :green_heart: cc 4m 33s the patch passed
+1 :green_heart: javac 4m 33s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 0m 14s /results-checkstyle-hbase-client.txt hbase-client: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)
+1 :green_heart: spotbugs 5m 9s the patch passed
+1 :green_heart: hadoopcheck 10m 26s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart: hbaseprotoc 1m 42s the patch passed
-1 :x: spotless 0m 16s patch has 21 errors when running spotless:check, run spotless:apply to fix.
_ Other Tests _
+1 :green_heart: asflicense 0m 32s The patch does not generate ASF License warnings.
51m 11s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6167
JIRA Issue HBASE-28770
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc
uname Linux 36182ff12b67 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / d989fadf297ba757c03933e45faa31112ee8d19d
Default Java Eclipse Adoptium-17.0.11+9
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/4/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count 86 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-endpoint U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/4/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 03 '24 18:09 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 27s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 9s master passed
+1 :green_heart: compile 2m 7s master passed
+1 :green_heart: javadoc 1m 3s master passed
+1 :green_heart: shadedjars 5m 46s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 7s the patch passed
+1 :green_heart: compile 2m 8s the patch passed
+1 :green_heart: javac 2m 8s the patch passed
+1 :green_heart: javadoc 1m 1s the patch passed
+1 :green_heart: shadedjars 5m 43s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 0m 34s hbase-protocol-shaded in the patch passed.
+1 :green_heart: unit 1m 32s hbase-client in the patch passed.
+1 :green_heart: unit 212m 45s hbase-server in the patch passed.
+1 :green_heart: unit 3m 24s hbase-endpoint in the patch passed.
248m 10s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6167
JIRA Issue HBASE-28770
Optional Tests javac javadoc unit compile shadedjars
uname Linux ecac800d1f05 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / d989fadf297ba757c03933e45faa31112ee8d19d
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/4/testReport/
Max. process+thread count 4897 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-endpoint U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/4/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 03 '24 22:09 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 27s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 1s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+0 :ok: buf 0m 0s buf was not available.
+0 :ok: buf 0m 0s buf was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 6s master passed
+1 :green_heart: compile 4m 46s master passed
+1 :green_heart: checkstyle 1m 7s master passed
+1 :green_heart: spotbugs 4m 58s master passed
+1 :green_heart: spotless 0m 45s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 2s the patch passed
+1 :green_heart: compile 4m 53s the patch passed
+1 :green_heart: cc 4m 53s the patch passed
+1 :green_heart: javac 4m 53s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 1m 5s the patch passed
+1 :green_heart: spotbugs 5m 23s the patch passed
+1 :green_heart: hadoopcheck 11m 32s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart: hbaseprotoc 1m 47s the patch passed
+1 :green_heart: spotless 0m 43s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 32s The patch does not generate ASF License warnings.
52m 16s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6167
JIRA Issue HBASE-28770
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc
uname Linux 7847d057f145 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 1a1c0c09d7f1b7f62745661156ac2dc3d704218b
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 86 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-endpoint U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/5/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 03 '24 23:09 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 26s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 13s master passed
+1 :green_heart: compile 2m 8s master passed
+1 :green_heart: javadoc 1m 3s master passed
+1 :green_heart: shadedjars 5m 47s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 4s the patch passed
+1 :green_heart: compile 2m 14s the patch passed
+1 :green_heart: javac 2m 14s the patch passed
+1 :green_heart: javadoc 1m 2s the patch passed
+1 :green_heart: shadedjars 5m 44s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 0m 33s hbase-protocol-shaded in the patch passed.
+1 :green_heart: unit 1m 36s hbase-client in the patch passed.
-1 :x: unit 215m 9s /patch-unit-hbase-server.txt hbase-server in the patch failed.
+1 :green_heart: unit 3m 56s hbase-endpoint in the patch passed.
251m 21s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6167
JIRA Issue HBASE-28770
Optional Tests javac javadoc unit compile shadedjars
uname Linux 7fa154e4810c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 1a1c0c09d7f1b7f62745661156ac2dc3d704218b
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/5/testReport/
Max. process+thread count 5348 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-endpoint U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/5/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 04 '24 02:09 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 32s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+0 :ok: buf 0m 0s buf was not available.
+0 :ok: buf 0m 0s buf was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 :ok: mvndep 0m 32s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 47s master passed
+1 :green_heart: compile 5m 52s master passed
+1 :green_heart: checkstyle 1m 27s master passed
+1 :green_heart: spotbugs 5m 57s master passed
+1 :green_heart: spotless 0m 47s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 26s the patch passed
+1 :green_heart: compile 5m 32s the patch passed
+1 :green_heart: cc 5m 32s the patch passed
+1 :green_heart: javac 5m 32s the patch passed
+1 :green_heart: blanks 0m 1s The patch has no blanks issues.
+1 :green_heart: checkstyle 1m 12s the patch passed
+1 :green_heart: spotbugs 6m 0s the patch passed
+1 :green_heart: hadoopcheck 11m 34s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart: hbaseprotoc 2m 7s the patch passed
+1 :green_heart: spotless 0m 52s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 42s The patch does not generate ASF License warnings.
58m 39s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6167
JIRA Issue HBASE-28770
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc
uname Linux 7d7a27efd7d0 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / cdeafb5584c3e42c3382b186ce8d0b109815b10f
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 84 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-endpoint U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/6/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 04 '24 19:09 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 51s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 37s Maven dependency ordering for branch
+1 :green_heart: mvninstall 4m 52s master passed
+1 :green_heart: compile 2m 44s master passed
+1 :green_heart: javadoc 1m 16s master passed
+1 :green_heart: shadedjars 6m 54s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 9s the patch passed
+1 :green_heart: compile 2m 11s the patch passed
+1 :green_heart: javac 2m 11s the patch passed
+1 :green_heart: javadoc 1m 3s the patch passed
+1 :green_heart: shadedjars 5m 43s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 0m 34s hbase-protocol-shaded in the patch passed.
+1 :green_heart: unit 1m 32s hbase-client in the patch passed.
+1 :green_heart: unit 217m 47s hbase-server in the patch passed.
+1 :green_heart: unit 3m 35s hbase-endpoint in the patch passed.
257m 53s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/6/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6167
JIRA Issue HBASE-28770
Optional Tests javac javadoc unit compile shadedjars
uname Linux 2a3eb64e2db2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / cdeafb5584c3e42c3382b186ce8d0b109815b10f
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/6/testReport/
Max. process+thread count 4368 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-endpoint U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/6/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 04 '24 22:09 Apache-HBase

Took a quick look, I still could not fully understand the mechanism here...

Please give me some time for a detailed look before merging...

Thanks.

Apache9 avatar Sep 05 '24 12:09 Apache9

Do you still need some time @Apache9 ?

ndimiduk avatar Sep 10 '24 09:09 ndimiduk

@Apache9 I've addressed some of your comments, still working on others.

charlesconnell avatar Sep 11 '24 11:09 charlesconnell

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 45s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+0 :ok: buf 0m 0s buf was not available.
+0 :ok: buf 0m 0s buf was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 :ok: mvndep 0m 47s Maven dependency ordering for branch
+1 :green_heart: mvninstall 5m 1s master passed
+1 :green_heart: compile 7m 8s master passed
+1 :green_heart: checkstyle 1m 40s master passed
+1 :green_heart: spotbugs 7m 25s master passed
+1 :green_heart: spotless 1m 13s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 17s Maven dependency ordering for patch
+1 :green_heart: mvninstall 5m 1s the patch passed
+1 :green_heart: compile 7m 2s the patch passed
+1 :green_heart: cc 7m 2s the patch passed
+1 :green_heart: javac 7m 2s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 1m 41s the patch passed
+1 :green_heart: spotbugs 8m 10s the patch passed
+1 :green_heart: hadoopcheck 15m 56s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart: hbaseprotoc 2m 58s the patch passed
+1 :green_heart: spotless 1m 8s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 59s The patch does not generate ASF License warnings.
78m 56s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/7/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6167
JIRA Issue HBASE-28770
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc
uname Linux 8d7a68861c08 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 356ef05ab7dd6663256f77c8e723b0e9e156d2b2
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 84 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-endpoint U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/7/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 11 '24 12:09 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 27s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 32s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 19s master passed
+1 :green_heart: compile 2m 9s master passed
+1 :green_heart: javadoc 1m 2s master passed
+1 :green_heart: shadedjars 5m 48s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 13s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 0s the patch passed
+1 :green_heart: compile 2m 9s the patch passed
+1 :green_heart: javac 2m 9s the patch passed
+1 :green_heart: javadoc 1m 2s the patch passed
+1 :green_heart: shadedjars 5m 42s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 0m 33s hbase-protocol-shaded in the patch passed.
+1 :green_heart: unit 1m 36s hbase-client in the patch passed.
+1 :green_heart: unit 211m 19s hbase-server in the patch passed.
+1 :green_heart: unit 3m 40s hbase-endpoint in the patch passed.
247m 28s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/7/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6167
JIRA Issue HBASE-28770
Optional Tests javac javadoc unit compile shadedjars
uname Linux f1bac6cc6464 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 356ef05ab7dd6663256f77c8e723b0e9e156d2b2
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/7/testReport/
Max. process+thread count 5068 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-endpoint U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/7/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 11 '24 15:09 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 28s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+0 :ok: buf 0m 0s buf was not available.
+0 :ok: buf 0m 0s buf was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 :ok: mvndep 0m 19s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 5s master passed
+1 :green_heart: compile 4m 59s master passed
+1 :green_heart: checkstyle 1m 6s master passed
+1 :green_heart: spotbugs 5m 4s master passed
+1 :green_heart: spotless 0m 45s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 8s the patch passed
+1 :green_heart: compile 5m 0s the patch passed
+1 :green_heart: cc 5m 0s the patch passed
+1 :green_heart: javac 5m 0s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 1m 4s the patch passed
+1 :green_heart: spotbugs 5m 31s the patch passed
+1 :green_heart: hadoopcheck 11m 34s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart: hbaseprotoc 1m 48s the patch passed
+1 :green_heart: spotless 0m 44s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 33s The patch does not generate ASF License warnings.
53m 5s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/8/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6167
JIRA Issue HBASE-28770
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc
uname Linux a78901b4a5ae 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 7ccd7c83068aa7f2fd617542294f96e72b7d602e
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 86 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-endpoint U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/8/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 13 '24 02:09 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 31s Docker mode activated.
-0 :warning: yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 44s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 28s master passed
+1 :green_heart: compile 2m 8s master passed
+1 :green_heart: javadoc 1m 3s master passed
+1 :green_heart: shadedjars 5m 47s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 5s the patch passed
+1 :green_heart: compile 2m 8s the patch passed
+1 :green_heart: javac 2m 8s the patch passed
+1 :green_heart: javadoc 1m 1s the patch passed
+1 :green_heart: shadedjars 5m 42s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 0m 34s hbase-protocol-shaded in the patch passed.
+1 :green_heart: unit 1m 31s hbase-client in the patch passed.
+1 :green_heart: unit 210m 26s hbase-server in the patch passed.
+1 :green_heart: unit 3m 30s hbase-endpoint in the patch passed.
246m 25s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/8/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6167
JIRA Issue HBASE-28770
Optional Tests javac javadoc unit compile shadedjars
uname Linux b558ddb5a32c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 7ccd7c83068aa7f2fd617542294f96e72b7d602e
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/8/testReport/
Max. process+thread count 4747 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-endpoint U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/8/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 13 '24 05:09 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 28s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+0 :ok: buf 0m 0s buf was not available.
+0 :ok: buf 0m 0s buf was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 15s master passed
+1 :green_heart: compile 4m 57s master passed
+1 :green_heart: checkstyle 1m 5s master passed
+1 :green_heart: spotbugs 5m 2s master passed
+1 :green_heart: spotless 0m 46s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for patch
-1 :x: mvninstall 3m 4s /patch-mvninstall-root.txt root in the patch failed.
-1 :x: compile 0m 16s /patch-compile-hbase-endpoint.txt hbase-endpoint in the patch failed.
-1 :x: cc 0m 16s /patch-compile-hbase-endpoint.txt hbase-endpoint in the patch failed.
-0 :warning: javac 0m 16s /patch-compile-hbase-endpoint.txt hbase-endpoint in the patch failed.
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 1m 4s the patch passed
-1 :x: spotbugs 0m 15s /patch-spotbugs-hbase-endpoint.txt hbase-endpoint in the patch failed.
-1 :x: hadoopcheck 2m 34s The patch causes 28 errors with Hadoop v3.3.6.
-1 :x: hadoopcheck 5m 11s The patch causes 28 errors with Hadoop v3.4.0.
-1 :x: hbaseprotoc 0m 15s /patch-hbaseprotoc-hbase-endpoint.txt hbase-endpoint in the patch failed.
+1 :green_heart: spotless 0m 44s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 33s The patch does not generate ASF License warnings.
40m 14s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/9/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6167
JIRA Issue HBASE-28770
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc
uname Linux 1ac451d52d3d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 7d7cae00eb94fbe3da31b73af6d8faf2da6d8731
Default Java Eclipse Adoptium-17.0.11+9
hadoopcheck https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/9/artifact/yetus-general-check/output/patch-javac-3.3.6.txt
hadoopcheck https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/9/artifact/yetus-general-check/output/patch-javac-3.4.0.txt
Max. process+thread count 86 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-endpoint U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/9/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 16 '24 13:09 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 33s Docker mode activated.
-0 :warning: yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 35s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 25s master passed
+1 :green_heart: compile 2m 6s master passed
+1 :green_heart: javadoc 1m 2s master passed
+1 :green_heart: shadedjars 5m 48s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
-1 :x: mvninstall 3m 6s /patch-mvninstall-root.txt root in the patch failed.
-1 :x: compile 0m 15s /patch-compile-hbase-endpoint.txt hbase-endpoint in the patch failed.
-0 :warning: javac 0m 15s /patch-compile-hbase-endpoint.txt hbase-endpoint in the patch failed.
-0 :warning: javadoc 0m 16s /results-javadoc-javadoc-hbase-client.txt hbase-client generated 2 new + 26 unchanged - 0 fixed = 28 total (was 26)
+1 :green_heart: shadedjars 5m 41s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 0m 33s hbase-protocol-shaded in the patch passed.
+1 :green_heart: unit 1m 36s hbase-client in the patch passed.
+1 :green_heart: unit 211m 56s hbase-server in the patch passed.
-1 :x: unit 0m 39s /patch-unit-hbase-endpoint.txt hbase-endpoint in the patch failed.
245m 19s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/9/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6167
JIRA Issue HBASE-28770
Optional Tests javac javadoc unit compile shadedjars
uname Linux c526eaff908d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 7d7cae00eb94fbe3da31b73af6d8faf2da6d8731
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/9/testReport/
Max. process+thread count 5171 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-endpoint U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/9/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 16 '24 16:09 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 27s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+0 :ok: buf 0m 0s buf was not available.
+0 :ok: buf 0m 0s buf was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 :ok: mvndep 0m 31s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 21s master passed
+1 :green_heart: compile 5m 4s master passed
+1 :green_heart: checkstyle 1m 7s master passed
+1 :green_heart: spotbugs 5m 7s master passed
+1 :green_heart: spotless 0m 46s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 4s the patch passed
+1 :green_heart: compile 4m 54s the patch passed
+1 :green_heart: cc 4m 54s the patch passed
+1 :green_heart: javac 4m 54s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 1m 5s the patch passed
+1 :green_heart: spotbugs 5m 28s the patch passed
+1 :green_heart: hadoopcheck 11m 40s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart: hbaseprotoc 1m 48s the patch passed
+1 :green_heart: spotless 0m 44s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 34s The patch does not generate ASF License warnings.
53m 42s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/10/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6167
JIRA Issue HBASE-28770
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc
uname Linux 8dbe0476cae9 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 31d131f748ba40d62f548aff3d231ff3a7312eb2
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 86 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-endpoint U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/10/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 16 '24 17:09 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 32s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 42s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 55s master passed
+1 :green_heart: compile 2m 48s master passed
+1 :green_heart: javadoc 1m 24s master passed
+1 :green_heart: shadedjars 6m 53s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 36s the patch passed
+1 :green_heart: compile 2m 27s the patch passed
+1 :green_heart: javac 2m 27s the patch passed
-0 :warning: javadoc 0m 18s /results-javadoc-javadoc-hbase-client.txt hbase-client generated 2 new + 26 unchanged - 0 fixed = 28 total (was 26)
+1 :green_heart: shadedjars 6m 18s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 0m 37s hbase-protocol-shaded in the patch passed.
+1 :green_heart: unit 1m 43s hbase-client in the patch passed.
-1 :x: unit 274m 17s /patch-unit-hbase-server.txt hbase-server in the patch failed.
+1 :green_heart: unit 4m 6s hbase-endpoint in the patch passed.
315m 57s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/10/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6167
JIRA Issue HBASE-28770
Optional Tests javac javadoc unit compile shadedjars
uname Linux a0f2d873c29f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 31d131f748ba40d62f548aff3d231ff3a7312eb2
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/10/testReport/
Max. process+thread count 4363 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-endpoint U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6167/10/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 16 '24 21:09 Apache-HBase

Test failure appears unrelated

charlesconnell avatar Sep 17 '24 12:09 charlesconnell

Nice one, thanks @charlesconnell, and thanks @Apache9 for the review!

ndimiduk avatar Sep 17 '24 13:09 ndimiduk

@charlesconnell Can you please post up a backport for branch-2? Thanks!

ndimiduk avatar Sep 17 '24 13:09 ndimiduk