HBASE-29325 Gson reflection failures on TestBucketCache.testCacheSimple

[wchevreuil]

[stoty]

The PR that has added this patch seems to expect that transient is excluded by default, as it added transient to several members.

TBH I'm not sure what we use the JSON serialization for. Is that only for logging/debugging ?

[Apache-HBase]

:broken_heart: -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 :ok:	reexec	0m 28s		Docker mode activated.
			_ Prechecks _
+1 :green_heart:	dupname	0m 0s		No case conflicting files found.
+0 :ok:	codespell	0m 0s		codespell was not available.
+0 :ok:	detsecrets	0m 0s		detect-secrets was not available.
+1 :green_heart:	@author	0m 0s		The patch does not contain any @author tags.
+1 :green_heart:	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+1 :green_heart:	mvninstall	3m 16s		master passed
+1 :green_heart:	compile	0m 40s		master passed
+1 :green_heart:	checkstyle	0m 14s		master passed
+1 :green_heart:	spotbugs	0m 31s		master passed
+1 :green_heart:	spotless	0m 45s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 :green_heart:	mvninstall	3m 2s		the patch passed
+1 :green_heart:	compile	0m 39s		the patch passed
+1 :green_heart:	javac	0m 39s		the patch passed
+1 :green_heart:	blanks	0m 0s		The patch has no blanks issues.
+1 :green_heart:	checkstyle	0m 13s		the patch passed
+1 :green_heart:	spotbugs	0m 37s		the patch passed
+1 :green_heart:	hadoopcheck	11m 55s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
-1 :x:	spotless	0m 14s		patch has 23 errors when running spotless:check, run spotless:apply to fix.
			_ Other Tests _
+1 :green_heart:	asflicense	0m 10s		The patch does not generate ASF License warnings.
		30m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6999/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/6999
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 63b131fdc74f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 27c6ca781c6bedbf1b6e832ae38df290c7e74726
Default Java	Eclipse Adoptium-17.0.11+9
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6999/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	83 (vs. ulimit of 30000)
modules	C: hbase-common U: hbase-common
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6999/1/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

:confetti_ball: +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 :ok:	reexec	0m 28s		Docker mode activated.
-0 :warning:	yetus	0m 2s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 :green_heart:	mvninstall	3m 16s		master passed
+1 :green_heart:	compile	0m 19s		master passed
+1 :green_heart:	javadoc	0m 17s		master passed
+1 :green_heart:	shadedjars	5m 57s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 :green_heart:	mvninstall	3m 8s		the patch passed
+1 :green_heart:	compile	0m 19s		the patch passed
+1 :green_heart:	javac	0m 19s		the patch passed
+1 :green_heart:	javadoc	0m 15s		the patch passed
+1 :green_heart:	shadedjars	5m 56s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 :green_heart:	unit	2m 13s		hbase-common in the patch passed.
		23m 15s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6999/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/6999
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 9dd8951e8add 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 27c6ca781c6bedbf1b6e832ae38df290c7e74726
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6999/1/testReport/
Max. process+thread count	399 (vs. ulimit of 30000)
modules	C: hbase-common U: hbase-common
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6999/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[wchevreuil]

The PR that has added this patch seems to expect that transient is expected by default, as it added transient to several members.

TBH I'm not sure what we use the JSON serialization for. Is that only for logging/debugging ?

I think transient was added as an attempt to get those fields ignored? But for some reason, GSON doesn't ignore it unless explicitly told to.

[Apache9]

+1 with stoty, is this more like a test problem or an actual problem in main code?

[wchevreuil]

+1 with stoty, is this more like a test problem or an actual problem in main code?

I have seen this manifesting on tests using specific JDK 17 implementations ("Java HotSpot(TM) 64-Bit Server VM (build 17.0.8+9-LTS-211)" and "OpenJDK Runtime Environment (build 17.0.15+6-Ubuntu-0ubuntu124.04)"). Apparently, "Eclipse Adoptium-17.0.11+9" works just fine, as we don't seen this in neither the precommits nor in nightly builds. I guess this error would blow up in any part of the code that tries to convert internal objects to json. I think this is mainly used on the UIs and logging.

[Apache-HBase]

:confetti_ball: +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 :ok:	reexec	0m 39s		Docker mode activated.
-0 :warning:	yetus	0m 2s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 :green_heart:	mvninstall	4m 35s		master passed
+1 :green_heart:	compile	0m 32s		master passed
+1 :green_heart:	javadoc	0m 26s		master passed
+1 :green_heart:	shadedjars	7m 56s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 :green_heart:	mvninstall	4m 37s		the patch passed
+1 :green_heart:	compile	0m 29s		the patch passed
+1 :green_heart:	javac	0m 29s		the patch passed
+1 :green_heart:	javadoc	0m 28s		the patch passed
+1 :green_heart:	shadedjars	8m 32s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 :green_heart:	unit	3m 35s		hbase-common in the patch passed.
		33m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6999/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/6999
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 7ede1182f6ae 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / fd495a1700ba9e75484ff3d7299777e68ce6a2f5
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6999/2/testReport/
Max. process+thread count	378 (vs. ulimit of 30000)
modules	C: hbase-common U: hbase-common
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6999/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

:confetti_ball: +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 :ok:	reexec	8m 42s		Docker mode activated.
			_ Prechecks _
+1 :green_heart:	dupname	0m 0s		No case conflicting files found.
+0 :ok:	codespell	0m 0s		codespell was not available.
+0 :ok:	detsecrets	0m 0s		detect-secrets was not available.
+1 :green_heart:	@author	0m 0s		The patch does not contain any @author tags.
+1 :green_heart:	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+1 :green_heart:	mvninstall	4m 57s		master passed
+1 :green_heart:	compile	3m 8s		master passed
+1 :green_heart:	checkstyle	0m 36s		master passed
+1 :green_heart:	spotbugs	1m 15s		master passed
+1 :green_heart:	spotless	1m 13s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 :green_heart:	mvninstall	6m 21s		the patch passed
+1 :green_heart:	compile	0m 51s		the patch passed
+1 :green_heart:	javac	0m 51s		the patch passed
+1 :green_heart:	blanks	0m 0s		The patch has no blanks issues.
+1 :green_heart:	checkstyle	0m 23s		the patch passed
+1 :green_heart:	spotbugs	1m 5s		the patch passed
+1 :green_heart:	hadoopcheck	24m 7s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart:	spotless	1m 30s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 :green_heart:	asflicense	0m 11s		The patch does not generate ASF License warnings.
		68m 33s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6999/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/6999
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux b1cb19d44892 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / fd495a1700ba9e75484ff3d7299777e68ce6a2f5
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	82 (vs. ulimit of 30000)
modules	C: hbase-common U: hbase-common
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6999/2/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache9]

We do not want to serialize private fields? Really? I think most POJOs are private fields with getter and setter?

[stoty]

We do not want to serialize private fields? Really? I think most POJOs are private fields with getter and setter?

The JSON serialization is used in a single test in debug log output.

If/when this will be needed again, the person doing the dbugging can figure out which fields they need and fix the JSON serialization. At least the test suite runs on the latest JDK with these changes.

[Apache-HBase]

:confetti_ball: +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 :ok:	reexec	0m 27s		Docker mode activated.
-0 :warning:	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 :green_heart:	mvninstall	3m 19s		master passed
+1 :green_heart:	compile	0m 19s		master passed
+1 :green_heart:	javadoc	0m 17s		master passed
+1 :green_heart:	shadedjars	6m 6s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 :green_heart:	mvninstall	3m 9s		the patch passed
+1 :green_heart:	compile	0m 19s		the patch passed
+1 :green_heart:	javac	0m 19s		the patch passed
+1 :green_heart:	javadoc	0m 15s		the patch passed
+1 :green_heart:	shadedjars	6m 4s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 :green_heart:	unit	2m 39s		hbase-common in the patch passed.
		23m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6999/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/6999
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux c222e269536a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / bbbf56765ae98dc9e34af8d89dd1304253331b1d
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6999/3/testReport/
Max. process+thread count	377 (vs. ulimit of 30000)
modules	C: hbase-common U: hbase-common
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6999/3/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

:confetti_ball: +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 :ok:	reexec	0m 36s		Docker mode activated.
			_ Prechecks _
+1 :green_heart:	dupname	0m 0s		No case conflicting files found.
+0 :ok:	codespell	0m 0s		codespell was not available.
+0 :ok:	detsecrets	0m 0s		detect-secrets was not available.
+1 :green_heart:	@author	0m 0s		The patch does not contain any @author tags.
+1 :green_heart:	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+1 :green_heart:	mvninstall	3m 20s		master passed
+1 :green_heart:	compile	0m 41s		master passed
+1 :green_heart:	checkstyle	0m 14s		master passed
+1 :green_heart:	spotbugs	0m 32s		master passed
+1 :green_heart:	spotless	0m 50s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 :green_heart:	mvninstall	3m 10s		the patch passed
+1 :green_heart:	compile	0m 40s		the patch passed
+1 :green_heart:	javac	0m 40s		the patch passed
+1 :green_heart:	blanks	0m 0s		The patch has no blanks issues.
+1 :green_heart:	checkstyle	0m 14s		the patch passed
+1 :green_heart:	spotbugs	0m 38s		the patch passed
+1 :green_heart:	hadoopcheck	12m 7s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart:	spotless	0m 45s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 :green_heart:	asflicense	0m 10s		The patch does not generate ASF License warnings.
		31m 34s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6999/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/6999
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux abc302469f18 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / bbbf56765ae98dc9e34af8d89dd1304253331b1d
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	84 (vs. ulimit of 30000)
modules	C: hbase-common U: hbase-common
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6999/3/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[stoty]

The JSON serialization is used in a single test in debug log output.

No it's not, we just got another ticket that demonstrates that it's also called by the UI from JSP.

[wchevreuil]

The JSON serialization is used in a single test in debug log output.

No it's not, we just got another ticket that demonstrates that it's also called by the UI from JSP.

Yeah, that's a problem. Imagine a file based bucket cache of TBs of data, the in-memory representation of the cache structure can easily grow to few GBs of RAM.

Parsing it into a String can cause potential problems for the RS.

I wonder if we should rather remove JSON deserialisation for BucketCache. Or at least put some safeguards that check for the size of the BucketCache object.

Also, ain't sure how useful such a large string would be.

[stoty]

Yes, using GSON to serializalize BucketCache is a clusterfuck.

We need to check if if / how much if it the UI needs, and find some solution.

[stoty]

I wonder if we should rather remove JSON deserialisation for BucketCache. Or at least put some safeguards that check for the size of the BucketCache object.

Yes, it's completely bonkers. On closer look, HBASE-29362 is not using the BucketCache object itself, so it's not really realted to this issue.

I totally agree that we should just remove all code that tries to use Gson to serialize complext multigigabyte in-memory cache objects with reflection.

TBH Gson itself looks like a spectaculrarly bad fit with modular JAva, and real objects. Maybe it's OK for simle POJO DTOs.

[stoty]

No it's not, we just got another ticket that demonstrates that it's also called by the UI from JSP.

We're calling GsonUtil from rits.jsp , but luckily that's creating a simple map for the values needed on the UI, and not doing anything stupid like trying to serialize BucketCache.

[wchevreuil]

No it's not, we just got another ticket that demonstrates that it's also called by the UI from JSP.

We're calling GsonUtil from rits.jsp , but luckily that's creating a simple map for the values needed on the UI, and not doing anything stupid like trying to serialize BucketCache.

There seems to be an option where we serialize the entire cache in the UI: https://github.com/apache/hbase/pull/7047/files#diff-a0cc60aec48986f0ec2377528ab6c26f248c246267b57145a1bd3ab9c7e42d07R60

[stoty]

You're right, we're doing that. Thanks for catching @wchevreuil .

[Apache9]

So how do we plan to fix this?

[stoty]

We've discussed this with @wchevreuil , the only sane ways seems to be removing any code that relies on serializing arbitrary multigigabyte internal objects (BucketCache) into JSON with reflection-happy Gson, @Apache9 .

We've found one log line, and one Web UI feature (which would probably kill the server and/or browser with the amount of data even if it worked properly)

[Apache9]

We've discussed this with @wchevreuil , the only sane ways seems to be removing any code that relies on serializing arbitrary multigigabyte internal objects (BucketCache) into JSON with reflection-happy Gson, @Apache9 .

We've found one log line, and one Web UI feature (which would probably kill the server and/or browser with the amount of data even if it worked properly)

So let's start the work? TestBucketCache is failing all the time...

[wchevreuil]

We've discussed this with @wchevreuil , the only sane ways seems to be removing any code that relies on serializing arbitrary multigigabyte internal objects (BucketCache) into JSON with reflection-happy Gson, @Apache9 . We've found one log line, and one Web UI feature (which would probably kill the server and/or browser with the amount of data even if it worked properly)

So let's start the work? TestBucketCache is failing all the time...

If we want to have the test passing (and guarantee that the related UI won't blow in jdks impl manifesting this issue), I can think on the following options:

1. Exclude private fields from the json generated by gson (this patch);
2. Replace Gson with something else that doesn't break in that way (quite a change);

Either way, we would still need to work on the problem @stoty mentioned (UI and logging generating json for potentially large objects).

Any other ideas or suggestions on which way to go @Apache9 @stoty ?

[Apache9]

I think @stoty proposed a more general way for solving the problem that we should not print all the things in BucketCache on our web UI...

For solving the problem for now, I think we can use a separated Gson instance for BucketCache serialization only, where we exclude the private fields, without touching the global Gson instance.

WDYT? @wchevreuil @stoty

Thanks.

[wchevreuil]

I think @stoty proposed a more general way for solving the problem that we should not print all the things in BucketCache on our web UI...

For solving the problem for now, I think we can use a separated Gson instance for BucketCache serialization only, where we exclude the private fields, without touching the global Gson instance.

WDYT? @wchevreuil @stoty

Thanks.

Sure. I have moved the private fields exclusion to the gson instance used by blockcache only.

The UI issue we can work on a separate jira, as it will require further work.

[Apache-HBase]

:broken_heart: -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 :ok:	reexec	0m 37s		Docker mode activated.
			_ Prechecks _
+1 :green_heart:	dupname	0m 0s		No case conflicting files found.
+0 :ok:	codespell	0m 0s		codespell was not available.
+0 :ok:	detsecrets	0m 0s		detect-secrets was not available.
+1 :green_heart:	@author	0m 0s		The patch does not contain any @author tags.
+1 :green_heart:	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 :ok:	mvndep	0m 12s		Maven dependency ordering for branch
+1 :green_heart:	mvninstall	4m 43s		master passed
+1 :green_heart:	compile	5m 30s		master passed
+1 :green_heart:	checkstyle	1m 22s		master passed
+1 :green_heart:	spotbugs	2m 49s		master passed
+1 :green_heart:	spotless	1m 5s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 :ok:	mvndep	0m 14s		Maven dependency ordering for patch
+1 :green_heart:	mvninstall	3m 50s		the patch passed
+1 :green_heart:	compile	4m 23s		the patch passed
+1 :green_heart:	javac	4m 23s		the patch passed
+1 :green_heart:	blanks	0m 0s		The patch has no blanks issues.
+1 :green_heart:	checkstyle	0m 57s		the patch passed
+1 :green_heart:	spotbugs	2m 49s		the patch passed
+1 :green_heart:	hadoopcheck	13m 6s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
-1 :x:	spotless	0m 49s		patch has 63 errors when running spotless:check, run spotless:apply to fix.
			_ Other Tests _
+1 :green_heart:	asflicense	0m 22s		The patch does not generate ASF License warnings.
		51m 31s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6999/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/6999
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 939c7dc23752 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 6de891dfae2d85e897ef2c5f1f011adb94c3e874
Default Java	Eclipse Adoptium-17.0.11+9
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6999/4/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	85 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6999/4/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

:broken_heart: -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 :ok:	reexec	0m 27s		Docker mode activated.
-0 :warning:	yetus	0m 2s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 :ok:	mvndep	0m 9s		Maven dependency ordering for branch
+1 :green_heart:	mvninstall	3m 2s		master passed
+1 :green_heart:	compile	1m 13s		master passed
+1 :green_heart:	javadoc	0m 43s		master passed
+1 :green_heart:	shadedjars	5m 49s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 :ok:	mvndep	0m 13s		Maven dependency ordering for patch
+1 :green_heart:	mvninstall	2m 54s		the patch passed
+1 :green_heart:	compile	1m 12s		the patch passed
+1 :green_heart:	javac	1m 12s		the patch passed
+1 :green_heart:	javadoc	0m 41s		the patch passed
+1 :green_heart:	shadedjars	5m 47s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 :green_heart:	unit	2m 11s		hbase-common in the patch passed.
-1 :x:	unit	214m 45s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		244m 17s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6999/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/6999
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux c07f696fbc13 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 6de891dfae2d85e897ef2c5f1f011adb94c3e874
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6999/4/testReport/
Max. process+thread count	4806 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6999/4/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

:confetti_ball: +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 :ok:	reexec	0m 45s		Docker mode activated.
			_ Prechecks _
+1 :green_heart:	dupname	0m 0s		No case conflicting files found.
+0 :ok:	codespell	0m 0s		codespell was not available.
+0 :ok:	detsecrets	0m 0s		detect-secrets was not available.
+1 :green_heart:	@author	0m 0s		The patch does not contain any @author tags.
+1 :green_heart:	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 :ok:	mvndep	0m 11s		Maven dependency ordering for branch
+1 :green_heart:	mvninstall	4m 42s		master passed
+1 :green_heart:	compile	4m 53s		master passed
+1 :green_heart:	checkstyle	0m 59s		master passed
+1 :green_heart:	spotbugs	2m 26s		master passed
+1 :green_heart:	spotless	0m 57s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 :ok:	mvndep	0m 12s		Maven dependency ordering for patch
+1 :green_heart:	mvninstall	4m 30s		the patch passed
+1 :green_heart:	compile	4m 49s		the patch passed
+1 :green_heart:	javac	4m 49s		the patch passed
+1 :green_heart:	blanks	0m 0s		The patch has no blanks issues.
+1 :green_heart:	checkstyle	0m 58s		the patch passed
+1 :green_heart:	spotbugs	2m 42s		the patch passed
+1 :green_heart:	hadoopcheck	17m 44s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart:	spotless	1m 9s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 :green_heart:	asflicense	0m 22s		The patch does not generate ASF License warnings.
		58m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6999/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/6999
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 754c267d3399 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / ac872b0c82a897d494e1ac33be7873a9ba981475
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	84 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6999/5/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

:confetti_ball: +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 :ok:	reexec	0m 47s		Docker mode activated.
-0 :warning:	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 :ok:	mvndep	0m 11s		Maven dependency ordering for branch
+1 :green_heart:	mvninstall	4m 43s		master passed
+1 :green_heart:	compile	1m 44s		master passed
+1 :green_heart:	javadoc	0m 54s		master passed
+1 :green_heart:	shadedjars	7m 8s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 :ok:	mvndep	0m 15s		Maven dependency ordering for patch
+1 :green_heart:	mvninstall	4m 32s		the patch passed
+1 :green_heart:	compile	1m 42s		the patch passed
+1 :green_heart:	javac	1m 42s		the patch passed
+1 :green_heart:	javadoc	0m 51s		the patch passed
+1 :green_heart:	shadedjars	6m 57s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 :green_heart:	unit	2m 50s		hbase-common in the patch passed.
+1 :green_heart:	unit	219m 28s		hbase-server in the patch passed.
		257m 9s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6999/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/6999
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 4cf7670b9296 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / ac872b0c82a897d494e1ac33be7873a9ba981475
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6999/5/testReport/
Max. process+thread count	5278 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6999/5/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache9]

@stoty Are you OK with the current approach for fixing TestBucketCache first?