HBASE-28792: AsyncTableImpl should call coprocessor callbacks in a defined order

[charlesconnell]

To call a coprocessor endpoint asynchronously, you start by calling AsyncTable#coprocessorService(), which gives you a CoprocessorServiceBuilder, and a few steps later you can talk to your coprocessor over the network. One argument to AsyncTable#coprocessorService() is a CoprocessorCallback object, which contains several methods that will be called during the lifecycle of a coprocessor endpoint call. AsyncTableImpl's implementation of AsyncTable#coprocessorService() wraps your CoprocessorCallback with its own that delegates the work to a thread pool. A snippet of this:

      @Override
      public void onRegionComplete(RegionInfo region, R resp) {
        pool.execute(context.wrap(() -> callback.onRegionComplete(region, resp)));
      }
...
      @Override
      public void onComplete() {
        pool.execute(context.wrap(callback::onComplete));
      }

The trouble with this is that your implementations of onRegionComplete() and onComplete() will end up getting called in a random order, and/or at the same time. The tasks of calling them are delegated to a thread pool, and the completion of those tasks is not waited on, so the thread pool can choose any ordering it wants to. Troublingly, onComplete() can be called before the final onRegionComplete(), which is an violation of the contract specified in the CoprocessorCallback#onComplete() javadoc.

This PR eliminates the use of a thread pool for calling the coprocessor callback, and calls them directly on the thread that received the response from the server.

[Apache-HBase]

:confetti_ball: +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 :ok:	reexec	0m 26s		Docker mode activated.
-0 :warning:	yetus	0m 2s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 :green_heart:	mvninstall	3m 4s		master passed
+1 :green_heart:	compile	0m 26s		master passed
+1 :green_heart:	javadoc	0m 18s		master passed
+1 :green_heart:	shadedjars	5m 38s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 :green_heart:	mvninstall	2m 51s		the patch passed
+1 :green_heart:	compile	0m 20s		the patch passed
+1 :green_heart:	javac	0m 20s		the patch passed
+1 :green_heart:	javadoc	0m 16s		the patch passed
+1 :green_heart:	shadedjars	5m 31s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 :green_heart:	unit	1m 35s		hbase-client in the patch passed.
		21m 33s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6168/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/6168
JIRA Issue	HBASE-28792
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux e96f94ef393c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / fee3060fe53510ce32d97103cca5ecb03da14605
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6168/1/testReport/
Max. process+thread count	324 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6168/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

:broken_heart: -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 :ok:	reexec	0m 28s		Docker mode activated.
			_ Prechecks _
+1 :green_heart:	dupname	0m 0s		No case conflicting files found.
+0 :ok:	codespell	0m 0s		codespell was not available.
+0 :ok:	detsecrets	0m 0s		detect-secrets was not available.
+1 :green_heart:	@author	0m 0s		The patch does not contain any @author tags.
+1 :green_heart:	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+1 :green_heart:	mvninstall	3m 9s		master passed
+1 :green_heart:	compile	0m 48s		master passed
+1 :green_heart:	checkstyle	0m 16s		master passed
+1 :green_heart:	spotbugs	0m 43s		master passed
+1 :green_heart:	spotless	0m 45s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 :green_heart:	mvninstall	2m 58s		the patch passed
+1 :green_heart:	compile	0m 46s		the patch passed
+1 :green_heart:	javac	0m 46s		the patch passed
+1 :green_heart:	blanks	0m 0s		The patch has no blanks issues.
+1 :green_heart:	checkstyle	0m 16s		the patch passed
+1 :green_heart:	spotbugs	0m 49s		the patch passed
+1 :green_heart:	hadoopcheck	12m 38s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
-1 :x:	spotless	0m 19s		patch has 37 errors when running spotless:check, run spotless:apply to fix.
			_ Other Tests _
+1 :green_heart:	asflicense	0m 10s		The patch does not generate ASF License warnings.
		31m 31s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6168/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/6168
JIRA Issue	HBASE-28792
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux e10de5bff610 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / fee3060fe53510ce32d97103cca5ecb03da14605
Default Java	Eclipse Adoptium-17.0.11+9
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6168/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	82 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6168/1/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

:confetti_ball: +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 :ok:	reexec	0m 26s		Docker mode activated.
-0 :warning:	yetus	0m 2s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 :green_heart:	mvninstall	2m 52s		master passed
+1 :green_heart:	compile	0m 21s		master passed
+1 :green_heart:	javadoc	0m 16s		master passed
+1 :green_heart:	shadedjars	5m 34s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 :green_heart:	mvninstall	2m 53s		the patch passed
+1 :green_heart:	compile	0m 21s		the patch passed
+1 :green_heart:	javac	0m 21s		the patch passed
+1 :green_heart:	javadoc	0m 16s		the patch passed
+1 :green_heart:	shadedjars	5m 35s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 :green_heart:	unit	1m 36s		hbase-client in the patch passed.
		21m 20s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6168/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/6168
JIRA Issue	HBASE-28792
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux a249c85a47c3 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 02b99bc30b8b81681a77ff895af126d4a517a55b
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6168/2/testReport/
Max. process+thread count	326 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6168/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

:confetti_ball: +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 :ok:	reexec	0m 26s		Docker mode activated.
			_ Prechecks _
+1 :green_heart:	dupname	0m 0s		No case conflicting files found.
+0 :ok:	codespell	0m 0s		codespell was not available.
+0 :ok:	detsecrets	0m 0s		detect-secrets was not available.
+1 :green_heart:	@author	0m 0s		The patch does not contain any @author tags.
+1 :green_heart:	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+1 :green_heart:	mvninstall	2m 54s		master passed
+1 :green_heart:	compile	0m 47s		master passed
+1 :green_heart:	checkstyle	0m 15s		master passed
+1 :green_heart:	spotbugs	0m 41s		master passed
+1 :green_heart:	spotless	0m 44s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 :green_heart:	mvninstall	2m 53s		the patch passed
+1 :green_heart:	compile	0m 48s		the patch passed
+1 :green_heart:	javac	0m 48s		the patch passed
+1 :green_heart:	blanks	0m 0s		The patch has no blanks issues.
+1 :green_heart:	checkstyle	0m 17s		the patch passed
+1 :green_heart:	spotbugs	0m 51s		the patch passed
+1 :green_heart:	hadoopcheck	10m 56s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart:	spotless	0m 43s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 :green_heart:	asflicense	0m 8s		The patch does not generate ASF License warnings.
		29m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6168/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/6168
JIRA Issue	HBASE-28792
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 0f6042e1bb57 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 02b99bc30b8b81681a77ff895af126d4a517a55b
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	82 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6168/2/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache9]

The intention here is that, in AsyncTableImpl, we will always call any callbacks in a thread pool, in order to prevent blocking operations in callbacks blocking the system thread(like netty event loop). If you want high performance, you can use RawAsyncTable directly.

Here I think we should still use the thread pool, but use some tricks to let onComplete to be called at last.

Thanks.

[Apache-HBase]

:confetti_ball: +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 :ok:	reexec	0m 27s		Docker mode activated.
-0 :warning:	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 :green_heart:	mvninstall	3m 11s		master passed
+1 :green_heart:	compile	0m 22s		master passed
+1 :green_heart:	javadoc	0m 18s		master passed
+1 :green_heart:	shadedjars	5m 44s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 :green_heart:	mvninstall	2m 59s		the patch passed
+1 :green_heart:	compile	0m 22s		the patch passed
+1 :green_heart:	javac	0m 22s		the patch passed
+1 :green_heart:	javadoc	0m 16s		the patch passed
+1 :green_heart:	shadedjars	5m 44s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 :green_heart:	unit	1m 38s		hbase-client in the patch passed.
		22m 2s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6168/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/6168
JIRA Issue	HBASE-28792
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux c15587d11129 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 334dcdeaab6e96b79fdaabb999b470f88690cd32
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6168/3/testReport/
Max. process+thread count	324 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6168/3/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

:confetti_ball: +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 :ok:	reexec	0m 28s		Docker mode activated.
			_ Prechecks _
+1 :green_heart:	dupname	0m 0s		No case conflicting files found.
+0 :ok:	codespell	0m 0s		codespell was not available.
+0 :ok:	detsecrets	0m 0s		detect-secrets was not available.
+1 :green_heart:	@author	0m 0s		The patch does not contain any @author tags.
+1 :green_heart:	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+1 :green_heart:	mvninstall	3m 18s		master passed
+1 :green_heart:	compile	0m 44s		master passed
+1 :green_heart:	checkstyle	0m 14s		master passed
+1 :green_heart:	spotbugs	0m 39s		master passed
+1 :green_heart:	spotless	0m 41s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 :green_heart:	mvninstall	2m 52s		the patch passed
+1 :green_heart:	compile	0m 44s		the patch passed
+1 :green_heart:	javac	0m 44s		the patch passed
+1 :green_heart:	blanks	0m 0s		The patch has no blanks issues.
+1 :green_heart:	checkstyle	0m 14s		the patch passed
+1 :green_heart:	spotbugs	0m 46s		the patch passed
+1 :green_heart:	hadoopcheck	10m 41s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart:	spotless	0m 43s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 :green_heart:	asflicense	0m 9s		The patch does not generate ASF License warnings.
		28m 51s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6168/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/6168
JIRA Issue	HBASE-28792
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 801851efa1b5 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 334dcdeaab6e96b79fdaabb999b470f88690cd32
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	83 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6168/3/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[charlesconnell]

@Apache9 Understood. I've brought back the thread pool usage and added a barrier to force onComplete() to wait until onRegionComplete() is done.

[Apache-HBase]

:confetti_ball: +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 :ok:	reexec	0m 29s		Docker mode activated.
-0 :warning:	yetus	0m 2s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 :ok:	mvndep	0m 13s		Maven dependency ordering for branch
+1 :green_heart:	mvninstall	2m 59s		master passed
+1 :green_heart:	compile	0m 39s		master passed
+1 :green_heart:	javadoc	0m 28s		master passed
+1 :green_heart:	shadedjars	5m 46s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 :ok:	mvndep	0m 12s		Maven dependency ordering for patch
+1 :green_heart:	mvninstall	3m 5s		the patch passed
+1 :green_heart:	compile	0m 39s		the patch passed
+1 :green_heart:	javac	0m 39s		the patch passed
+1 :green_heart:	javadoc	0m 27s		the patch passed
+1 :green_heart:	shadedjars	5m 42s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 :green_heart:	unit	1m 39s		hbase-client in the patch passed.
+1 :green_heart:	unit	3m 33s		hbase-endpoint in the patch passed.
		27m 1s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6168/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/6168
JIRA Issue	HBASE-28792
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux b03b74e31383 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / f6943805f9bfd4c0260e84e6ff349f1d2ca45c92
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6168/4/testReport/
Max. process+thread count	1379 (vs. ulimit of 30000)
modules	C: hbase-client hbase-endpoint U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6168/4/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

:confetti_ball: +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 :ok:	reexec	0m 26s		Docker mode activated.
			_ Prechecks _
+1 :green_heart:	dupname	0m 0s		No case conflicting files found.
+0 :ok:	codespell	0m 0s		codespell was not available.
+0 :ok:	detsecrets	0m 0s		detect-secrets was not available.
+1 :green_heart:	@author	0m 0s		The patch does not contain any @author tags.
+1 :green_heart:	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 :ok:	mvndep	0m 12s		Maven dependency ordering for branch
+1 :green_heart:	mvninstall	2m 51s		master passed
+1 :green_heart:	compile	1m 8s		master passed
+1 :green_heart:	checkstyle	0m 22s		master passed
+1 :green_heart:	spotbugs	1m 1s		master passed
+1 :green_heart:	spotless	0m 42s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 :ok:	mvndep	0m 10s		Maven dependency ordering for patch
+1 :green_heart:	mvninstall	2m 49s		the patch passed
+1 :green_heart:	compile	1m 7s		the patch passed
+1 :green_heart:	javac	1m 7s		the patch passed
+1 :green_heart:	blanks	0m 0s		The patch has no blanks issues.
+1 :green_heart:	checkstyle	0m 22s		the patch passed
+1 :green_heart:	spotbugs	1m 16s		the patch passed
+1 :green_heart:	hadoopcheck	10m 33s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart:	spotless	0m 42s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 :green_heart:	asflicense	0m 16s		The patch does not generate ASF License warnings.
		30m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6168/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/6168
JIRA Issue	HBASE-28792
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux ceb493f1a87b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / f6943805f9bfd4c0260e84e6ff349f1d2ca45c92
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	82 (vs. ulimit of 30000)
modules	C: hbase-client hbase-endpoint U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6168/4/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

:confetti_ball: +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 :ok:	reexec	0m 29s		Docker mode activated.
-0 :warning:	yetus	0m 2s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 :ok:	mvndep	0m 11s		Maven dependency ordering for branch
+1 :green_heart:	mvninstall	2m 55s		master passed
+1 :green_heart:	compile	0m 39s		master passed
+1 :green_heart:	javadoc	0m 28s		master passed
+1 :green_heart:	shadedjars	5m 43s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 :ok:	mvndep	0m 12s		Maven dependency ordering for patch
+1 :green_heart:	mvninstall	3m 3s		the patch passed
+1 :green_heart:	compile	0m 39s		the patch passed
+1 :green_heart:	javac	0m 39s		the patch passed
+1 :green_heart:	javadoc	0m 27s		the patch passed
+1 :green_heart:	shadedjars	5m 41s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 :green_heart:	unit	1m 39s		hbase-client in the patch passed.
+1 :green_heart:	unit	3m 35s		hbase-endpoint in the patch passed.
		26m 52s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6168/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/6168
JIRA Issue	HBASE-28792
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 67120d50615e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 82cef8b51d43c2c1b9c4865683fd310b85806632
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6168/5/testReport/
Max. process+thread count	1396 (vs. ulimit of 30000)
modules	C: hbase-client hbase-endpoint U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6168/5/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

:confetti_ball: +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 :ok:	reexec	0m 47s		Docker mode activated.
			_ Prechecks _
+1 :green_heart:	dupname	0m 0s		No case conflicting files found.
+0 :ok:	codespell	0m 0s		codespell was not available.
+0 :ok:	detsecrets	0m 0s		detect-secrets was not available.
+1 :green_heart:	@author	0m 0s		The patch does not contain any @author tags.
+1 :green_heart:	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 :ok:	mvndep	0m 11s		Maven dependency ordering for branch
+1 :green_heart:	mvninstall	2m 51s		master passed
+1 :green_heart:	compile	1m 7s		master passed
+1 :green_heart:	checkstyle	0m 22s		master passed
+1 :green_heart:	spotbugs	1m 1s		master passed
+1 :green_heart:	spotless	0m 41s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 :ok:	mvndep	0m 11s		Maven dependency ordering for patch
+1 :green_heart:	mvninstall	2m 50s		the patch passed
+1 :green_heart:	compile	1m 7s		the patch passed
+1 :green_heart:	javac	1m 7s		the patch passed
+1 :green_heart:	blanks	0m 0s		The patch has no blanks issues.
+1 :green_heart:	checkstyle	0m 22s		the patch passed
+1 :green_heart:	spotbugs	1m 16s		the patch passed
+1 :green_heart:	hadoopcheck	10m 34s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart:	spotless	0m 41s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 :green_heart:	asflicense	0m 15s		The patch does not generate ASF License warnings.
		31m 2s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6168/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/6168
JIRA Issue	HBASE-28792
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 7c63059ed1dd 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 82cef8b51d43c2c1b9c4865683fd310b85806632
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	84 (vs. ulimit of 30000)
modules	C: hbase-client hbase-endpoint U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6168/5/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

:confetti_ball: +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 :ok:	reexec	0m 26s		Docker mode activated.
-0 :warning:	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 :ok:	mvndep	0m 38s		Maven dependency ordering for branch
+1 :green_heart:	mvninstall	3m 17s		master passed
+1 :green_heart:	compile	0m 38s		master passed
+1 :green_heart:	javadoc	0m 27s		master passed
+1 :green_heart:	shadedjars	5m 34s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 :ok:	mvndep	0m 12s		Maven dependency ordering for patch
+1 :green_heart:	mvninstall	2m 55s		the patch passed
+1 :green_heart:	compile	0m 37s		the patch passed
+1 :green_heart:	javac	0m 37s		the patch passed
+1 :green_heart:	javadoc	0m 26s		the patch passed
+1 :green_heart:	shadedjars	5m 36s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 :green_heart:	unit	1m 36s		hbase-client in the patch passed.
+1 :green_heart:	unit	3m 31s		hbase-endpoint in the patch passed.
		27m 9s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6168/6/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/6168
JIRA Issue	HBASE-28792
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 1e9ab3d364db 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 5573a60cd7d664a8529b04329e59a3ace7817da3
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6168/6/testReport/
Max. process+thread count	1383 (vs. ulimit of 30000)
modules	C: hbase-client hbase-endpoint U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6168/6/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

:confetti_ball: +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 :ok:	reexec	0m 31s		Docker mode activated.
			_ Prechecks _
+1 :green_heart:	dupname	0m 0s		No case conflicting files found.
+0 :ok:	codespell	0m 0s		codespell was not available.
+0 :ok:	detsecrets	0m 0s		detect-secrets was not available.
+1 :green_heart:	@author	0m 0s		The patch does not contain any @author tags.
+1 :green_heart:	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 :ok:	mvndep	0m 10s		Maven dependency ordering for branch
+1 :green_heart:	mvninstall	3m 30s		master passed
+1 :green_heart:	compile	1m 27s		master passed
+1 :green_heart:	checkstyle	0m 31s		master passed
+1 :green_heart:	spotbugs	1m 26s		master passed
+1 :green_heart:	spotless	0m 59s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 :ok:	mvndep	0m 11s		Maven dependency ordering for patch
+1 :green_heart:	mvninstall	3m 21s		the patch passed
+1 :green_heart:	compile	1m 23s		the patch passed
+1 :green_heart:	javac	1m 23s		the patch passed
+1 :green_heart:	blanks	0m 0s		The patch has no blanks issues.
+1 :green_heart:	checkstyle	0m 29s		the patch passed
+1 :green_heart:	spotbugs	1m 35s		the patch passed
+1 :green_heart:	hadoopcheck	12m 13s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart:	spotless	0m 53s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 :green_heart:	asflicense	0m 21s		The patch does not generate ASF License warnings.
		36m 49s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6168/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/6168
JIRA Issue	HBASE-28792
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 8ada949607ee 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 5573a60cd7d664a8529b04329e59a3ace7817da3
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	82 (vs. ulimit of 30000)
modules	C: hbase-client hbase-endpoint U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6168/6/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache9]

Ah, just 5 minutes late...

LGTM.

Thanks @charlesconnell and @ndimiduk !

[ndimiduk]

All good. Welcome back @Apache9 !