Duo Zhang

Results 364 comments of Duo Zhang

I think we may have more patterns when replication... For example, we want to replicate a whole namespace and change the target namespace name, we want to replicate all the...

Mind taking a look at HBASE-28521? In general, we want to avoid leaking the internal zookeeper, so for replication, we want to use the standard connection registry API to connect...

#5825 is not necessary for solving the problem for this PR, #5835 is enough, as after #5835, we are able to customize the ZKClientConfig through the Configuration map in the...

> @Apache9 If I understand correctly #5835 have solved [HBASE-28464](https://issues.apache.org/jira/browse/HBASE-28464) and made this PR obsolete. Why should we rebase the PR here? Am I missing something? You are right... I...

Since these libraries use commons-logging as their logging facade, excluding commons-logging may introduce troubles like ClassNotFoundException? And at least, we can not see the logs of these libraries?

Jcl-over-slf4j is just a commons-logging implementation based on slf4j, so we still need the commons-logging facade? IIRC, commons-logging is mostly like slf4j, usually you will use commons-logging and log4j together...

Ah, OK, checked the code, seems jcl-over-slf4j contains the class in commons-logging...

Better also ban commons-logging import in the maven enforcer plugin?