hbase icon indicating copy to clipboard operation
hbase copied to clipboard

HBASE-29237 TableLatency occasionally not being updated after regions close and open

Open Reidddddd opened this issue 9 months ago • 6 comments

https://issues.apache.org/jira/browse/HBASE-29237

Reidddddd avatar Apr 01 '25 04:04 Reidddddd

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 29s Docker mode activated.
-0 :warning: yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 18s master passed
+1 :green_heart: compile 0m 16s master passed
+1 :green_heart: javadoc 0m 13s master passed
+1 :green_heart: shadedjars 5m 59s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 3s the patch passed
+1 :green_heart: compile 0m 12s the patch passed
+1 :green_heart: javac 0m 12s the patch passed
+1 :green_heart: javadoc 0m 11s the patch passed
+1 :green_heart: shadedjars 5m 54s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 0m 18s hbase-metrics in the patch passed.
20m 52s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6872/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6872
Optional Tests javac javadoc unit compile shadedjars
uname Linux aefe4d0f48fb 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 4b67584d8689e9ef7c734443a335284f91de3f02
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6872/1/testReport/
Max. process+thread count 185 (vs. ulimit of 30000)
modules C: hbase-metrics U: hbase-metrics
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6872/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Apr 01 '25 04:04 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 27s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 18s master passed
+1 :green_heart: compile 0m 17s master passed
+1 :green_heart: checkstyle 0m 7s master passed
+1 :green_heart: spotbugs 0m 19s master passed
+1 :green_heart: spotless 0m 45s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 3s the patch passed
+1 :green_heart: compile 0m 18s the patch passed
+1 :green_heart: javac 0m 18s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 0m 8s the patch passed
+1 :green_heart: spotbugs 0m 24s the patch passed
+1 :green_heart: hadoopcheck 11m 48s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
-1 :x: spotless 0m 13s patch has 23 errors when running spotless:check, run spotless:apply to fix.
_ Other Tests _
+1 :green_heart: asflicense 0m 10s The patch does not generate ASF License warnings.
28m 40s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6872/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6872
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 659d2442b4ac 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 4b67584d8689e9ef7c734443a335284f91de3f02
Default Java Eclipse Adoptium-17.0.11+9
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6872/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count 83 (vs. ulimit of 30000)
modules C: hbase-metrics U: hbase-metrics
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6872/1/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Apr 01 '25 04:04 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 28s Docker mode activated.
-0 :warning: yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 1s master passed
+1 :green_heart: compile 0m 11s master passed
+1 :green_heart: javadoc 0m 10s master passed
+1 :green_heart: shadedjars 5m 56s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 4s the patch passed
+1 :green_heart: compile 0m 11s the patch passed
+1 :green_heart: javac 0m 11s the patch passed
+1 :green_heart: javadoc 0m 10s the patch passed
+1 :green_heart: shadedjars 5m 54s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 :green_heart: unit 0m 19s hbase-metrics in the patch passed.
20m 15s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6872/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6872
Optional Tests javac javadoc unit compile shadedjars
uname Linux 3f627f3c8b1c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 206faf00d9befc3245e1572864d55470f01552b6
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6872/2/testReport/
Max. process+thread count 195 (vs. ulimit of 30000)
modules C: hbase-metrics U: hbase-metrics
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6872/2/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Apr 01 '25 06:04 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 31s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 :green_heart: mvninstall 4m 13s master passed
+1 :green_heart: compile 0m 26s master passed
+1 :green_heart: checkstyle 0m 10s master passed
+1 :green_heart: spotbugs 0m 21s master passed
+1 :green_heart: spotless 0m 51s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 42s the patch passed
+1 :green_heart: compile 0m 23s the patch passed
+1 :green_heart: javac 0m 23s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 0m 9s the patch passed
+1 :green_heart: spotbugs 0m 44s the patch passed
+1 :green_heart: hadoopcheck 18m 18s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 :green_heart: spotless 0m 58s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 15s The patch does not generate ASF License warnings.
40m 43s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6872/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/6872
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 542c51a33572 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 206faf00d9befc3245e1572864d55470f01552b6
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 81 (vs. ulimit of 30000)
modules C: hbase-metrics U: hbase-metrics
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6872/2/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Apr 01 '25 06:04 Apache-HBase

This PR is not correct still and more complicated than I thought.

Need second thoughts.

Reidddddd avatar Apr 09 '25 07:04 Reidddddd

This PR is not correct still and more complicated than I thought.

Need second thoughts.

I think at least the code can fix one concurrency problem, are there any other problems? @Reidddddd

Apache9 avatar May 22 '25 14:05 Apache9