Duo Zhang

Results 364 comments of Duo Zhang

What I mean is that, the logic here is correct, so in general, if everything works as expected, you can not archive the file, even if you mark it as...

So this is a problem when refactoring? IIRC we abstract some common logic to AbstractFSWAL on branch-2, but the implementation is still a bit different from master and branch-3. We...

OK, in the old time, if there are unflushed entries, we will throw IOException out and abort the region server... When optimizing the close logic, we finally changed the code...

Just ignore the Hadoop 3.4.0 Hadoop check failure. The branch itself is broken.

@bbeaudreault I think you are more familiar with this area? Do you have sometime to review this? Thanks.

Ah, never mind. I'm also a bit busy recently, for getting a new job. I will try to find sometime review this PR in the next few days. Thanks.

Could you please provide the jira issue number about which change in hadoop 3.x breaks HBase? We can not simply change hadoop to 3.3.x by default, as there are still...

HBase 2.4.x has already been EOL. Does this problem also affects other branches? Thanks.

Then please open a PR against branch-2(which is for 2.7.x), or if branch-2 is not affected, please open a PR against branch-2.6. In HBase usually we will open a PR...