Shashwat Vangani
Shashwat Vangani
Updated from [pr3010.19](https://github.com/shaavan/rust-lightning/commits/pr3010.19) to [pr3010.20](https://github.com/shaavan/rust-lightning/commits/pr3010.20) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3010.19..pr3010.20)): Addressed @jkczyz comments Changes: 1. Include `Nonce` as the field in `AwaitingInvoice` instead of `Context`, since `Nonce` is sufficient for context recreation, and safeguards...
Updated from [pr3010.20](https://github.com/shaavan/rust-lightning/commits/pr3010.20) to [pr3010.21](https://github.com/shaavan/rust-lightning/commits/pr3010.21) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3010.20..pr3010.21)): Addressed @jkczyz comments Changes: 1. Removed redundant clone. 2. Make nonce and Option, instead of required to support downgrading.
Updated from [pr3010.21](https://github.com/shaavan/rust-lightning/commits/pr3010.21) to [pr3010.22](https://github.com/shaavan/rust-lightning/commits/pr3010.22) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3010.21..pr3010.22)): Addressed @jkczyz comments Changes: 1. Fixed tlv number of nonce, to follow the "it's okay to be odd" rule. 2. Fixed release pending onion...
Updated from [pr3010.22](https://github.com/shaavan/rust-lightning/commits/pr3010.22) to [pr3010.23](https://github.com/shaavan/rust-lightning/commits/pr3010.23) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3010.22..pr3010.23)): Changes: 1. Rebase on main to resolve merge conflicts. 2. Squash fixup commit 3. No changes to the approach in this version. Range-Diff: ```diff...
Updated from [pr3010.23](https://github.com/shaavan/rust-lightning/commits/pr3010.23) to [pr3010.24](https://github.com/shaavan/rust-lightning/commits/pr3010.24) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3010.23..pr3010.24)): Addressed @vincenzopalazzo, and @jkczyz comments Changes: 1. Introduce RetryableInvoiceRequest struct, which contains all the data required to recreate InvoiceRequest Messages. 2. Upgrade logging level...
Updated from [pr3010.24](https://github.com/shaavan/rust-lightning/commits/pr3010.24) to [pr3010.25](https://github.com/shaavan/rust-lightning/commits/pr3010.25) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3010.24..pr3010.25)): Addressed @jkczyz comments Changes: 1. Remove a redundant `clone`. 2. Rename `handle_message_received` -> `message_received`, and update docs to align with the function's purpose. 3....
Updated from [pr3010.25](https://github.com/shaavan/rust-lightning/commits/pr3010.25) to [pr3010.26](https://github.com/shaavan/rust-lightning/commits/pr3010.26) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3010.25..pr3010.26)): Addressed @TheBlueMatt comments 1. Update `add_new_awaiting_invoice` to only update the `awaiting_invoice` flag if there is some `retryable_invoice_request`. 2. Update `message_received` docs.
Updated from [pr3010.26](https://github.com/shaavan/rust-lightning/commits/pr3010.26) to [pr3010.27](https://github.com/shaavan/rust-lightning/commits/pr3010.27) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3010.26..pr3010.27)): Addressed @jkczyz comment Changes: 1. Use a `if` conditional, instead of `map` for a more idiomatic construct for `retryable_invoice_request`.
Would love to take a look into this!
Hi @jbesraa! I got involved with some other commitments and couldn’t find time to work on this properly! Feel free to take this up, if you’d like! :)