Shashwat Vangani
Shashwat Vangani
Updated from [pr3010.10](https://github.com/shaavan/rust-lightning/commits/pr3010.10) to [pr3010.11](https://github.com/shaavan/rust-lightning/commits/pr3010.11) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3010.10..pr3010.11)): Changes: 1. Rebase on main, to resolve merge conflicts.
@TheBlueMatt A gentle ping! :)
Updated from [pr3010.11](https://github.com/shaavan/rust-lightning/commits/pr3010.11) to [pr3010.12](https://github.com/shaavan/rust-lightning/commits/pr3010.12) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3010.11..pr3010.12)): Addressed @TheBlueMatt comments Changes: 1. Updated the `handle_message_received` documentation to be more generic, removing references to BOLT12. 2. Removed the return `Result` type for...
Updated from [pr3010.12](https://github.com/shaavan/rust-lightning/commits/pr3010.12) to [pr3010.13](https://github.com/shaavan/rust-lightning/commits/pr3010.13) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3010.12..pr3010.13)): Addressed @TheBlueMatt comments Updates: 1. Change the memory ordering from `SeqCst` to `Acquire` and `Release`. 2. Moved the storing of `awaiting_invoice_flag` from `pay_for_offer` to...
Updated from [pr3010.13](https://github.com/shaavan/rust-lightning/commits/pr3010.13) to [pr3010.14](https://github.com/shaavan/rust-lightning/commits/pr3010.14) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3010.13..pr3010.14)): Updates: 1. Rebase on main, to fix ci. 2. Update `get_invoice_request_awaiting_invoice` to return vector of (payment_id, invoice_request). This is done so that channelmanager's `handle_message_received`...
Updated from [pr3010.14](https://github.com/shaavan/rust-lightning/commits/pr3010.14) to [pr3010.15](https://github.com/shaavan/rust-lightning/commits/pr3010.15) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3010.14..pr3010.15)): Addressed @jkczyz comments Updates: 1. Refactor the Outbound Payment Constructor to make the lock, and flag private members. 2. Moved the create_invoice_request_message below pay_for_offer...
Updated from [pr3010.15](https://github.com/shaavan/rust-lightning/commits/pr3010.15) to [pr3010.16](https://github.com/shaavan/rust-lightning/commits/pr3010.16) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3010.15..pr3010.16)): Addressed @jkczyz comments 1. Calculate `reply_path` prior to locking the `pending_offers_message` mutex in `handle_message_received`.
Updated from [pr3010.16](https://github.com/shaavan/rust-lightning/commits/pr3010.16) to [pr3010.17](https://github.com/shaavan/rust-lightning/commits/pr3010.17) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3010.16..pr3010.17)): Addressed @jkczyz comments Updates: 1. Renames function and variable name to be more apt to their usage. 2. Update test to remove improve comment...
Updated from [pr3010.17](https://github.com/shaavan/rust-lightning/commits/pr3010.17) to [pr3010.18](https://github.com/shaavan/rust-lightning/commits/pr3010.18) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3010.17..pr3010.18)): Addressed @jkczyz comments Changes: 1. Squashed commits together. 2. Some code cleanups.
Updated from [pr3010.18](https://github.com/shaavan/rust-lightning/commits/pr3010.18) to [pr3010.19](https://github.com/shaavan/rust-lightning/commits/pr3010.19) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3010.18..pr3010.19)): Addressed @jkczyz comments **Changes:** With the merge of #3139, the Invoice Request message now needs both the Invoice Request as well as the original...